1027682 - [Flame][Build] Failed to build on Mac OS X 10.9, elf.h file not found

Status: VERIFIED FIXED

Description

[Krzysztof Mioduszewski[:tauzen]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36

Steps to reproduce:

Building flame on Mac OS X 10.9 fails with:
B2G/kernel/scripts/mod/mk_elfconfig.c:4:10: fatal error: 'elf.h' file not found

Workaround: copy elf.h from B2G source to /usr/local/include. I actually did:

> cp B2G/external/elfutils/libelf/elf.h /usr/local/include

Comment 1

[Blake Wu [:bwu][:blakewu]]

Hi Jed, 
I use your patch[1] and it works well!
Would you mind checking in your patch to code base? 


[1]https://github.com/jld/gp-keon-kernel/commit/eea28ab16ab90ed5713f19989126682864c1f8ec.patch

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-6⟩ ⟦he/him⟧]

Attachment: Link to GitHub pull request for codeaurora_kernel_msm

Sorry for the delay.  This is just the patch linked in comment #1, applied with git-am to the flame-kk branch.  I confirmed that the build still works on Linux with this patch; comment #1 confirms that it works on Mac, so I didn't re-test that case.

In case the license on the header is a concern: it's used only for build tools run on the host, not as part of the kernel image, and it's effectively just a restatement of part of the ELF specification in any case.

Comment 3

[Michael Wu [:mwu]]

Comment on attachment 8534731 [details] [review]
Link to GitHub pull request for codeaurora_kernel_msm

Good stuff.

I'm not too worried about putting LGPL code into a repo that is GPL.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-6⟩ ⟦he/him⟧]

https://github.com/mozilla-b2g/codeaurora_kernel_msm/commit/48b6a2c9fde18f2f7d9abddf05261c498c2bb2ba

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

confirming that I can build b2g again on mac os!