1027718 - Bugzilla::Sentry fails with error if mod_perl is not installed on the system

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[David Lawrence [:dkl]]

If mod_perl is not installed, the following fatal error can occur:

    Software error:
     
    Can't locate Apache2/Log.pm in @INC (@INC contains: . lib /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at Bugzilla/Sentry.pm line 19.
    BEGIN failed--compilation aborted at Bugzilla/Sentry.pm line 19.
    Compilation failed in require at Bugzilla/Error.pm line 31.
    BEGIN failed--compilation aborted at Bugzilla/Error.pm line 31.
    Compilation failed in require at Bugzilla/Auth.pm line 34.
    BEGIN failed--compilation aborted at Bugzilla/Auth.pm line 34.
    Compilation failed in require at Bugzilla.pm line 38.
    BEGIN failed--compilation aborted at Bugzilla.pm line 38.
    Compilation failed in require at /home/vagrant/htdocs/bmo/index.cgi line 34.
    BEGIN failed--compilation aborted at /home/vagrant/htdocs/bmo/index.cgi line 34.
     
    For help, please send mail to the webmaster (root@localhost), giving this error message and the time and date of the error. 

We should add mod_perl to the required list of modules (as opposed to optional) for BMO installations. Even if mod_perl is not actually enabled.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: 1027718_1.patch

Added to Config.pm instead of putting conditionals in Bugzilla/Sentry.pm because eventually we will want to test BMO using TravisCI. And Build.PL gets the dependencies from the extensions Config files and we will want the Apache modules installed for us.

dkl

Comment 3

[:glob ✱]

Comment on attachment 8442915 [details] [diff] [review]
1027718_1.patch

Review of attachment 8442915 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/BMO/Config.pm
@@ +45,5 @@
> +        package => 'Apache-SizeLimit',
> +        module  => 'Apache2::SizeLimit',
> +        # 0.96 properly determines process size on Linux.
> +        version => '0.96',
> +    },

sentry support isn't part of the bmo extension, so this isn't the correct place for these requirements.

it would be better to update the sentry code to 'require' the apache2 modules instead.

Comment 4

[David Lawrence [:dkl]]

Attachment: 1027718_2.patch

Also removed Apache2::SubProcess as it doesn't seem to be used anymore.

Comment 5

[:glob ✱]

Comment on attachment 8443534 [details] [diff] [review]
1027718_2.patch

Review of attachment 8443534 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 6

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   d7b36fd..f16dc32  master -> master