1027725 - Make calendar app async operations use promises

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

See proposal here https://github.com/gaye/calendar-refactor/blob/master/proposals/promises.md.

Comment 1

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21716

I was thinking that we could go ahead and wrap the existing node-style callback stuff with this so that we can have a gradualish migration from the existing node-style callback backend apis to promises. Thoughts guys?

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8455540 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21716

Positive feedback from :lightsofapollo and :millermedeiros on irc so bumping to preliminary review. Preliminary since I am meaning to add a couple tests for the new access modes on provider/store stuff.

Comment 3

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8455540 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21716

I liked the tests and also the flexibility - supporting both styles will allow us to migrate the code gradually. And +1 for the helper method to denodeify all methods at once. Just a small nit about IIFE (unsure if it's needed).

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Landed on master. Thanks for working with me on this Miller! https://github.com/mozilla-b2g/gaia/commit/5edca8cd06409b8bf404de4adf7ea08fc2940fd7