Closed Bug 1027725 Opened 9 years ago Closed 9 years ago

Make calendar app async operations use promises

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S6 (18july)

People

(Reporter: gaye, Assigned: gaye)

References

Details

(Whiteboard: [priority][p=5])

Attachments

(1 file)

Summary: Make async operations use promises → Make calendar app async operations use promises
Blocks: 1027729
Whiteboard: [priority]
Blocks: 1027728
No longer blocks: 1027729
Target Milestone: --- → 2.0 S5 (4july)
I was thinking that we could go ahead and wrap the existing node-style callback stuff with this so that we can have a gradualish migration from the existing node-style callback backend apis to promises. Thoughts guys?
Assignee: nobody → gaye
Attachment #8455540 - Flags: feedback?(mmedeiros)
Attachment #8455540 - Flags: feedback?(jlal)
Comment on attachment 8455540 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21716

Positive feedback from :lightsofapollo and :millermedeiros on irc so bumping to preliminary review. Preliminary since I am meaning to add a couple tests for the new access modes on provider/store stuff.
Attachment #8455540 - Flags: review?(mmedeiros)
Attachment #8455540 - Flags: feedback?(mmedeiros)
Attachment #8455540 - Flags: feedback?(jlal)
Comment on attachment 8455540 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21716

I liked the tests and also the flexibility - supporting both styles will allow us to migrate the code gradually. And +1 for the helper method to denodeify all methods at once. Just a small nit about IIFE (unsure if it's needed).
Attachment #8455540 - Flags: review?(mmedeiros) → review+
Landed on master. Thanks for working with me on this Miller! https://github.com/mozilla-b2g/gaia/commit/5edca8cd06409b8bf404de4adf7ea08fc2940fd7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [priority] → [priority][p=5]
Target Milestone: 2.0 S5 (4july) → 2.0 S6 (18july)
You need to log in before you can comment on or make changes to this bug.