Switch from deprecated FILL_PARENT to MATCH_PARENT in Java and XML

RESOLVED FIXED in Firefox 33

Status

()

Firefox for Android
General
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: bnicholson, Assigned: Hathibelagal A, Mentored)

Tracking

Trunk
Firefox 33
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
We have tons of deprecated FILL_PARENT usages in our tree:

http://mxr.mozilla.org/mozilla-central/search?string=fill_parent&find=base&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

These should all be switched to MATCH_PARENT.

Updated

4 years ago
Mentor: bnicholson
Whiteboard: [mentor=bnicholson][lang=java] → [lang=java]

Updated

4 years ago
Whiteboard: [lang=java] → [lang=java][good first bug]
(Assignee)

Comment 1

4 years ago
Created attachment 8443424 [details] [diff] [review]
p1.patch - Occurrences of "fill_parent" have been replaced with "match_parent", and occurrences of FILL_PARENT with MATCH_PARENT.

Occurrences of "fill_parent" have been replaced with "match_parent", and occurrences of FILL_PARENT with MATCH_PARENT.
(Assignee)

Updated

4 years ago
Attachment #8443424 - Flags: review?(bnicholson)
(Assignee)

Updated

4 years ago
Attachment #8443424 - Attachment is obsolete: true
Attachment #8443424 - Flags: review?(bnicholson)
(Assignee)

Comment 2

4 years ago
Created attachment 8443443 [details] [diff] [review]
1027831.patch - Replaced occurrences of fill_parent with match_parent, and FILL_PARENT with MATCH_PARENT

Replaced occurrences of fill_parent with match_parent in the XML files, and FILL_PARENT with MATCH_PARENT in the .java files.
Attachment #8443443 - Flags: review?(bnicholson)
(Reporter)

Comment 3

4 years ago
Comment on attachment 8443443 [details] [diff] [review]
1027831.patch - Replaced occurrences of fill_parent with match_parent, and FILL_PARENT with MATCH_PARENT

Review of attachment 8443443 [details] [diff] [review]:
-----------------------------------------------------------------

Looks perfect, thanks!
Attachment #8443443 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 5

4 years ago
Thanks! This is my first bug fix. Could you please help me push this code? Is there anything I need to do to make it happen?
(Reporter)

Comment 6

4 years ago
I already took care of that for you in comment 4. :)

Normally, you would ask for try server access (https://tbpl.mozilla.org/?tree=Try), push your patch there to make sure it passes all of our tests, then set the checkin-needed flag in the bug for a volunteer to land for you.

In this case, however, you have a patch that touches many files, so I wanted to land it ASAP to minimize bitrot. The changes in the patch are also quite trivial, and have a very low chance of breaking anything.
https://hg.mozilla.org/mozilla-central/rev/426fabc9a7fa
Assignee: nobody → hathymo
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
You need to log in before you can comment on or make changes to this bug.