Closed
Bug 102785
Opened 23 years ago
Closed 23 years ago
js debugger [jsd3250.dll] is loaded on startup (win32)
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jrgmorrison, Assigned: rginda)
References
Details
(Keywords: perf)
Attachments
(1 file)
5.07 KB,
patch
|
dp
:
review+
shaver
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
I noticed that with the Javascript debugger now built by default, we are loading its DLL (jsd3250.dll) at startup. Seems like the sort of thing that should happen lazily, since (despite the wonderful goodness that this is) this is a feature that only some subset of all users will ever use the debugger.
Assignee | ||
Comment 1•23 years ago
|
||
venkman registers an app start observer, to allow the user to set a pref indicating that the debugger should be initialized at startup. It does not create an instance of the service unless the pref is set (see js/jsd/jsd_xpc.cpp.) XPCOM is free to unload the service, if it does that kind of thing. If this is an embedding issue, then maybe the embedding builds should turn off venkman.
Reporter | ||
Comment 2•23 years ago
|
||
No, this isn't an embedding issue per se. I just noticed that it was loaded, and filed the bug since, in principle, any dll that does not need to be loaded during startup should be deferred. If it needs to be loaded, then it needs to be loaded. If there is some other way to refactor this to avoid loading the DLL though, then maybe that could be considered. At any rate, I leave it to the pros to figure out what to do with this (i.e., what is the right balance).
Updated•23 years ago
|
Assignee | ||
Comment 3•23 years ago
|
||
Frankly, the feature I'm trying to provide is currently broken. If loading the debugger is a real startup perf hit, I could try figure a compromise between performance and functionality. If it's something that causes a large hit NOW, I'm ok with backing out the startup listener, which would prevent the service from being loaded at startup.
Comment 4•23 years ago
|
||
Yes please remove it from being loaded on startup. We have been on a crusade to eliminate dlls that get loaded on startup. 1/2 the startup time is spent loading dlls.
Assignee | ||
Comment 5•23 years ago
|
||
Comment on attachment 52158 [details] [diff] [review] patch removes app start listener from debugger service sr=shaver
Attachment #52158 -
Flags: superreview+
Comment 8•23 years ago
|
||
Comment on attachment 52158 [details] [diff] [review] patch removes app start listener from debugger service r=dp
Attachment #52158 -
Flags: review+
Comment 9•23 years ago
|
||
Comment on attachment 52158 [details] [diff] [review] patch removes app start listener from debugger service a=asa (on behalf of drivers) for checkin to 0.9.5.
Attachment #52158 -
Flags: approval+
Assignee | ||
Comment 10•23 years ago
|
||
checked in to branch and trunk
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 11•22 years ago
|
||
Verify fixed. no more loading on startup.
Status: RESOLVED → VERIFIED
QA Contact: rginda → caillon
Updated•19 years ago
|
Product: Core → Other Applications
Updated•5 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•