102785 - js debugger [jsd3250.dll] is loaded on startup (win32)

Status: VERIFIED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[John Morrison]

I noticed that with the Javascript debugger now built by default, we are 
loading its DLL (jsd3250.dll) at startup. Seems like the sort of thing that 
should happen lazily, since (despite the wonderful goodness that this is) this 
is a feature that only some subset of all users will ever use the debugger.

Comment 1

[Robert Ginda]

venkman registers an app start observer, to allow the user to set a pref
indicating that the debugger should be initialized at startup.  It does not
create an instance of the service unless the pref is set (see
js/jsd/jsd_xpc.cpp.)  XPCOM is free to unload the service, if it does that kind
of thing.

If this is an embedding issue, then maybe the embedding builds should turn off
venkman.

Comment 2

[John Morrison]

No, this isn't an embedding issue per se. I just noticed that it was loaded,
and filed the bug since, in principle, any dll that does not need to be loaded
during startup should be deferred. If it needs to be loaded, then it needs to 
be loaded. If there is some other way to refactor this to avoid loading the 
DLL though, then maybe that could be considered. At any rate, I leave it to the 
pros to figure out what to do with this (i.e., what is the right balance).

Comment 3

[Robert Ginda]

Frankly, the feature I'm trying to provide is currently broken.  If loading the
debugger is a real startup perf hit, I could try figure a compromise between
performance and functionality.  If it's something that causes a large hit NOW,
I'm ok with backing out the startup listener, which would prevent the service
from being loaded at startup.

Comment 4

[Suresh Duddi (gone)]

Yes please remove it from being loaded on startup. We have been on a crusade to
eliminate dlls that get loaded on startup. 1/2 the startup time is spent loading
dlls.

Comment 5

[Robert Ginda]

Attachment: patch removes app start listener from debugger service

Comment 6

[Robert Ginda]

s/sr anyone?

Comment 7

[Mike Shaver (:shaver emeritus)]

Comment on attachment 52158 [details] [diff] [review]
patch removes app start listener from debugger service

sr=shaver

Comment 8

[Suresh Duddi (gone)]

Comment on attachment 52158 [details] [diff] [review]
patch removes app start listener from debugger service

r=dp

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 52158 [details] [diff] [review]
patch removes app start listener from debugger service

a=asa (on behalf of drivers) for checkin to 0.9.5.

Comment 10

[Robert Ginda]

checked in to branch and trunk

Comment 11

[Christopher Aillon (sabbatical, not receiving bugmail)]

Verify fixed.  no more loading on startup.