1027852 - AudioNode Inspector should evaluate floats without a leading 0

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

When altering a property on an AudioNode, like a GainNode's "gain", I should be able to enter in `.1` and have that set the gain to `0.1`.

Currently we `JSON.parse` the string entered into the VariablesView, so this fix would be in the `_onEval` method in `browser/devtools/webaudioeditor/webaudioeditor-view.js`

Comment 1

[Raphaël Lustin [:rlustin] [:rlubitel] [:lubitel]]

Attachment: AudioNode Inspector should evaluate floats without a leading 0. r=jsantell

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Looks great! Can we add a test for this? Probably best to add a quick float test in this one:

./browser/devtools/webaudioeditor/test/browser_wa_properties-view-edit.js

Note: this test is disabled due to intermittent failures on our test servers, so you will have to uncomment it out in the `browser.ini` in that directory to run it. If you're new to running tests on devtools components, check this out: https://wiki.mozilla.org/DevTools/Hacking#DevTools_Mochitests

Thanks!!

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8443968 [details] [diff] [review]
AudioNode Inspector should evaluate floats without a leading 0. r=jsantell

Review of attachment 8443968 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, lets just get some tests in there :)

Comment 4

[Raphaël Lustin [:rlustin] [:rlubitel] [:lubitel]]

Hi Jordan,

Thanks for the review and the tip. I'll write some tests :)

Comment 5

[Raphaël Lustin [:rlustin] [:rlubitel] [:lubitel]]

Attachment: AudioNode Inspector should evaluate floats without a leading 0. r=jsantell

Comment 6

[Raphaël Lustin [:rlustin] [:rlubitel] [:lubitel]]

Attachment: AudioNode Inspector should evaluate floats without a leading 0. r=jsantell

Comment 7

[Raphaël Lustin [:rlustin] [:rlubitel] [:lubitel]]

Attachment: AudioNode Inspector should evaluate floats without a leading 0. r=jsantell

Write some tests.

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8444043 [details] [diff] [review]
AudioNode Inspector should evaluate floats without a leading 0. r=jsantell

Review of attachment 8444043 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Tests passing (although still commented out in the browser.ini due to the other intermittent failure, but this will turn on when that does).

Small nit, lets get consistent quotes (double) in the tests -- once that's done, I'll merge this in. Thanks Raphaël!

Comment 9

[Raphaël Lustin [:rlustin] [:rlubitel] [:lubitel]]

Attachment: AudioNode Inspector should evaluate floats without a leading 0. r=jsantell

Comment 10

[Raphaël Lustin [:rlustin] [:rlubitel] [:lubitel]]

Comment on attachment 8444587 [details] [diff] [review]
AudioNode Inspector should evaluate floats without a leading 0. r=jsantell

Review of attachment 8444587 [details] [diff] [review]:
-----------------------------------------------------------------

Here is the last nit you asked for.

Comment 11

[(PTO June 19-July 7) Ryan VanderMeulen]

Please verify that this is green on Try before pushing.

Comment 12

[Jordan Santell [:jsantell] [@jsantell]]

Pushing to try: https://tbpl.mozilla.org/?tree=Try&rev=1c36e65dc5d9

Comment 13

[Jordan Santell [:jsantell] [@jsantell]]

Try test looking good

Comment 14

[Raphaël Lustin [:rlustin] [:rlubitel] [:lubitel]]

Do I have to do something to checkin the patch?

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/447f4ece45a5

Comment 16

[Jordan Santell [:jsantell] [@jsantell]]

Raphaël -- the sheriffs will check it in (just like Carsten did above) -- they'll mark the bug as resolved in a day or two if nothing terrible breaks :)

Comment 17

[Raphaël Lustin [:rlustin] [:rlubitel] [:lubitel]]

Jordan -- thanks for the explanation, I discovered the process :)

Comment 18

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/447f4ece45a5