1027872 - Visits are empty for (all?) apps

Status: RESOLVED FIXED

(Marketplace Graveyard :: Statistics, defect, P2)

Description

[sil-persona]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140608211622

Steps to reproduce:

1. Visit https://marketplace.firefox.com/statistics/app/riddling/visits/?start=2014-05-19&end=2014-06-18 which is the statistics page for Visits for my app, Riddling.



Actual results:

2. The main graph says "This data is restricted or no data found".
3. The downloadable JSON file looks like this:

{"objects":[{"count":null,"date":"2014-05-19"},{"count":null,"date":"2014-05-20"}, ... ,{"count":null,"date":"2014-06-17"},{"count":null,"date":"2014-06-18"}]}

Each date has count:null


Expected results:

2. The graph should show some visit data; I myself at least have visited the app in the Marketplace.
3. The downloadable JSON should also reflect these visits. At the very least, I'd expect count to be 0 on days without visits; count being null suggests that something is being wrongly recorded.

Comment 1

[Andrew Williamson [:eviljeff]]

I think this might be a wider issue affecting other apps too.

Comment 2

[Andrew Williamson [:eviljeff]]

I'm seeing the same thing for apps that we know should have 1000s of visits, e.g.

https://marketplace.firefox.com/statistics/app/line/visits/?start=2014-05-19&end=2014-06-18

Comment 3

[Rob Hudson [:robhudson]]

It appears that we switched to the universal analytics but the Monolith code wasn't updated. I'm looking into updating the monolith queries to pull in the visits correctly.

Comment 4

[Rob Hudson [:robhudson]]

Fixed in:
https://github.com/mozilla/monolith-aggregator/commit/ab38ac84 and
https://github.com/mozilla/monolith-aggregator/commit/c7db999b

We updated the new variable name under universal analytics. We also keep the old variable name for backfills and data overlaps while client side code go updated over the few days after it went out.

Comment 5

[sil-persona]

I'm still not seeing any statistics on the marketplace page linked above, and all counts are still null. Perhaps this is fixed but not deployed?

Comment 6

[Andrew Williamson [:eviljeff]]

(In reply to sil-persona from comment #5)
> I'm still not seeing any statistics on the marketplace page linked above,
> and all counts are still null. Perhaps this is fixed but not deployed?

yes, see the target milestone for the deployment date

Comment 7

[Victor Carciu]

Verified this on mp-dev. Stats are not null  : http://screencast.com/t/42itUYUq

Comment 8

[sil-persona]

I can confirm that visits stats are no longer null. Installs stats still seem to be null: https://marketplace.firefox.com/statistics/app/riddling/installs/?start=2014-07-27&end=2014-07-31 shows the "This data is restricted or no data found" thing. Again, I expect that there *have* been no installs, but I'd still expect install count in the data to be 0, not null, for those dates.

Comment 9

[sil-persona]

This seems to have regressed; https://marketplace.firefox.com/statistics/app/riddling/visits/?start=2014-07-04&end=2014-08-03 shows all the visits data as being null again.

Comment 10

[sil-persona]

And it's still null for Riddling. As far as I can tell I'm not allowed to re-open this bug, but it is not fixed.

Comment 11

[Atul Varma [:atul]]

Can I reopen it? Lemme see...

Comment 12

[Andrew Williamson [:eviljeff]]

Note this time Line's stats are showing (thought I can't immediately say if they're correct) so its not all apps.

Comment 13

[Rob Hudson [:robhudson]]

I spot checked a handful of apps from the popular apps list and all the visits appear to be working as expected.

For Riddling in particular I looked at Marketplace stats and see no data. I then queried the Google Analytics backend from Jun to Oct and only see 1 hit.

So the data collection seems to be working and appears to be valid.

FWIW, we only store values in Monolith (our stats backend) if it is non-zero. So a null and a zero are treated the same.

Comment 14

[sil-persona]

I mentioned Riddling at the weekend in a talk. At least one person downloaded it. At least one other tried to (and got told it wasn't available in their area). Those visits and downloads are not showing in the stats.

Comment 15

[Rob Hudson [:robhudson]]

(In reply to sil-persona from comment #14)
> I mentioned Riddling at the weekend in a talk. At least one person
> downloaded it. At least one other tried to (and got told it wasn't available
> in their area). Those visits and downloads are not showing in the stats.

There are a couple things that could be happening:

If a person searches for "riddling", finds it via search, and installs it from the search results page, this will not record a "visit". A "visit" is a hit to the app's detail page directly, not a listing in the search results.

Also, we respect Do Not Track with regards to analytics. If a person has enabled Do Not Track and visits the detail page we will still not record it. See bug 1032941.

Comment 16

[sil-persona]

Aaaah. The visits thing explains it. Thank you for the clarification!

Comment 17

[Andrew Williamson [:eviljeff]]

(In reply to Rob Hudson [:robhudson] from comment #15)
> (In reply to sil-persona from comment #14)
> > I mentioned Riddling at the weekend in a talk. At least one person
> > downloaded it. At least one other tried to (and got told it wasn't available
> > in their area). Those visits and downloads are not showing in the stats.
> 
> There are a couple things that could be happening:
> 
> If a person searches for "riddling", finds it via search, and installs it
> from the search results page, this will not record a "visit". A "visit" is a
> hit to the app's detail page directly, not a listing in the search results.
> '
> Also, we respect Do Not Track with regards to analytics. If a person has
> enabled Do Not Track and visits the detail page we will still not record it.
> See bug 1032941.

wouldn't the install still be showing though?  

Another oddity (possibly entirely unrelated) is that some of the 'empty' views look different to others.
c.f https://marketplace.firefox.com/statistics/app/riddling/installs/?start=2014-06-07&end=2014-10-07 and https://marketplace.firefox.com/statistics/app/riddling/installs/?start=2014-07-07&end=2014-10-07
- the former shows a chart of 0 points and the latter says 'This data is restricted or no data found'