1027925 - [Vertical Homescreen] Cannot delete an app while downloading it

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Johan Lorenzo [:jlorenzo]]

STR
1. Download a packaged application
2. While downloading enter edit mode
3. Tap the delete button

Expected result
In 1.4, the app is deleted.

Actual result
In today's master, the delete button is present but doesn't do anything.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Parity with 1.4.

Comment 2

[James Lal [:lightsofapollo]]

After trying this for a bit I found that I can actually delete the app but the touch target is very small to actually hit the little "X" icon rather then the icon itself... Can you confirm?

Comment 3

[James Lal [:lightsofapollo]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/20824

Basing this on top of the app error state refresh (which also improves this by changing the z-index of the loading bar). Essentially this is a test that ensures this functionality works better for humans and a padding increase of the remove button.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8443697 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20824

I'm going to start reviewing your big patch shortly.

Comment 5

[Johan Lorenzo [:jlorenzo]]

I confirm. Sometimes the X button can be hit.

Comment 6

[James Lal [:lightsofapollo]]

Green on try: https://github.com/mozilla-b2g/gaia/commit/a659aed91e6b47ff269066fab9a73b03cda2c98d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/c346c67283b6de4aa4813d3a89ab61783229026d

Comment 8

[Sue]

Attachment: video of issue verify

This issue has been verified successfully on Flame v2.0 & v2.1
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.0 versions:
Gaia-Rev        f9d6e3d83c3922e9399a6c27f5ce4cdd27bdfd05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/45112935086f
Build-ID        20141126000203
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141126.032754
FW-Date         Wed Nov 26 03:28:05 EST 2014
Bootloader      L1TC00011880

Flame 2.1 versions:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141126.033519
FW-Date         Wed Nov 26 03:35:30 EST 2014
Bootloader      L1TC00011880