1027992 - Throw an exception when we can't get nsIGlobalObject to create Promise.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Jocelyn Liu [:jocelyn] [:joliu]]

This bug is to solve the problem that has been pointed out by Boris in bug1006310.
In BluetoothAdapter::Enable() and BluetoothAdapter::Disable(), nullptr is returned directly and doesn't match the webidl.

Comment 1

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Bug 1027992 - Patch: Throws an exception when Promise can't be created for enable/disable adapter requests.

Hi Boris,

This patch is fixing the same issue you had been pointed out in
https://bugzilla.mozilla.org/show_bug.cgi?id=1006310#c8.
We also returned nullptr directly in BluetoothAdapter::Enable() and BluetoothAdapter::Disable().
Could you review our webidl and implementation change for fixing this problem?

Thanks,
Jocelyn

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8443227 [details] [diff] [review]
Bug 1027992 - Patch: Throws an exception when Promise can't be created for enable/disable adapter requests.

r=me

Comment 3

[Boris Zbarsky [:bzbarsky]]

Oh, and s/Throws/Throw/ in the commit message, please.

Comment 4

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [Final] Bug 1027992 - Patch: Throw an exception when Promise can't be created for enable/disable adapter requests. r=bz

Comment 5

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/a9a08cf67547

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a9a08cf67547