Closed Bug 1027996 Opened 7 years ago Closed 7 years ago

Telephony marionette test: change emulator.run to promise version

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S5 (4july)

People

(Reporter: aknow, Assigned: aknow)

Details

Attachments

(3 files, 3 obsolete files)

No description provided.
Attachment #8443299 - Flags: review?(htsai)
Comment on attachment 8443299 [details] [diff] [review]
Part 1: Change emulator.run to promise version

Review of attachment 8443299 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/test/marionette/head.js
@@ +89,5 @@
>  
>    /**
>     * @return Promise
>     */
> +  function waitNoCall() {

How about s/waitNoCall/waitForNoCall/?
Attachment #8443299 - Flags: review?(htsai) → review+
Comment on attachment 8443300 [details] [diff] [review]
Part 2: For tests: Rename emulator.run to emulator.runWithCallback

Review of attachment 8443300 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. You will need to rebase on the latest m-c.
Attachment #8443300 - Flags: review?(htsai) → review+
Attachment #8443301 - Flags: review?(htsai) → review+
https://tbpl.mozilla.org/?tree=Try&rev=b0d8e82cd006
Keywords: checkin-needed
Target Milestone: --- → 2.0 S5 (4july)
You need to log in before you can comment on or make changes to this bug.