1027996 - Telephony marionette test: change emulator.run to promise version

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 1: Change emulator.run to promise version

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 2: For tests: Rename emulator.run to emulator.runWithCallback

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 3: For tests: No need to check emulator OK result

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8443299 [details] [diff] [review]
Part 1: Change emulator.run to promise version

Review of attachment 8443299 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/test/marionette/head.js
@@ +89,5 @@
>  
>    /**
>     * @return Promise
>     */
> +  function waitNoCall() {

How about s/waitNoCall/waitForNoCall/?

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8443300 [details] [diff] [review]
Part 2: For tests: Rename emulator.run to emulator.runWithCallback

Review of attachment 8443300 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. You will need to rebase on the latest m-c.

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Part 1: Change emulator.run to promise version. r=hsinyi

Comment 7

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Part 2: For tests: Rename emulator.run to emulator.runWithCallback. r=hsinyi

Comment 8

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Part 3: For tests: No need to check emulator OK result. r=hsinyi

Comment 9

[Szu-Yu Chen [:aknow] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=b0d8e82cd006

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/caabccda7337
https://hg.mozilla.org/integration/b2g-inbound/rev/af844092eefa
https://hg.mozilla.org/integration/b2g-inbound/rev/1095558b4e46

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/caabccda7337
https://hg.mozilla.org/mozilla-central/rev/af844092eefa
https://hg.mozilla.org/mozilla-central/rev/1095558b4e46