1028048 - [ringtones] touch targets in create screen are off (part 2)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Description

[Jim Porter (:squib)]

+++ This bug was initially created as a clone of Bug #1017416 +++

STR
1. Have music on device
2. Go to Settings -> Sound -> Manage Ringtones
3. Tap New in upper right
4. Select song
5. Tap UI in create screen

Expected:
Tapping on the element does action

Actual:
Tapping next to the element does the action - see video attachments

(In reply to Jim Porter (:squib) from bug 1017416 comment #26)
> So right now, this is what we do to create a new ringtone from the ringtone
> manager:
> 
> 1) Open the ringtone manager as an inline activity from the settings app
> 2) Click "+" which opens a pick activity, launching the music app
> 3) Pick a song from the music app, which returns the result to the ringtone
> manager
> 4) Taking the result from the pick activity, use window.open to open
> share.html and send it the pick activity's data via postMessage once
> share.html has loaded.
> 
> The main issue I'm seeing right now is that when you try to tap the "X"
> button in the top left of share.html, it doesn't work and we get this error
> in the logcat:
> 
> E/GeckoConsole( 1840): [JavaScript Error: "TypeError:
> StackManager.getCurrent(...) is null" {file:
> "app://system.gaiamobile.org/js/edge_swipe_detector.js" line: 118}]
> 
> If the steps I laid out above are a bad way of doing what I want, let me
> know. Basically, I'm trying to emulate a share activity entirely within the
> ringtones app. I guess I could make it a *real* share activity, but I don't
> want anyone else to be able to handle that activity.

Comment 1

[Jason Smith [:jsmith]]

Followup to a 2.0+ blocker.

Comment 3

[Hema Koka [:hema]]

Etienne,

Jim says that you may be the best one to look into this as it may be related to edge gestures. Can you help figure out whats going on here. 

Thanks
Hema

Comment 4

[Etienne Segonzac (:etienne)]

(In reply to Hema Koka [:hema] from comment #3)
> Etienne,
> 
> Jim says that you may be the best one to look into this as it may be related
> to edge gestures. Can you help figure out whats going on here. 
> 

Yes I'll have a look today, just tested and there's no issue with controls at the center of the screen anymore. Which is good because it makes it an edge-only issue now.

Comment 5

[Hema Koka [:hema]]

(In reply to Etienne Segonzac (:etienne) from comment #4)
> (In reply to Hema Koka [:hema] from comment #3)
> > Etienne,
> > 
> > Jim says that you may be the best one to look into this as it may be related
> > to edge gestures. Can you help figure out whats going on here. 
> > 
> 
> Yes I'll have a look today, just tested and there's no issue with controls
> at the center of the screen anymore. Which is good because it makes it an
> edge-only issue now.

Thanks so much Etienne! Assigning this to you.

Comment 6

[Tiffanie Shakespeare [:tif]]

Hi Etienne! While dogfooding I noticed that a very similar issue happens with Contact picker. Here are the STR:

1. Open mail and compose an email.
2. Tap the plus to open the contact picker
3. Try tapping on a letter

Actual
Contact list jumps down to that letter

Expected
Nothing happens. Only by tapping more to the left of the letter are you able to jump to the section.

Comment 7

[Etienne Segonzac (:etienne)]

(In reply to Tiffanie Shakespeare from comment #6)
> Hi Etienne! While dogfooding I noticed that a very similar issue happens
> with Contact picker. Here are the STR:
> 
> 1. Open mail and compose an email.
> 2. Tap the plus to open the contact picker
> 3. Try tapping on a letter
> 
> Actual
> Contact list jumps down to that letter
> 
> Expected
> Nothing happens. Only by tapping more to the left of the letter are you able
> to jump to the section.

Thank you so much!
Found the issue with these STR, a patch will come soon.

Comment 8

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8447281 [details] [review]
Gaia PR

Makes perfect sense. r+.

Comment 10

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/b77f122bcb82c87e368b68ecbba212317cda5ba8

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/cf28d813ffb72b81bb8ee707ba0d5e742988457e

Comment 12

[SandKing]

This issue has been verified successfully on Flame2.1/Flame2.0
Verify video: "verify_1028048.MP4"
Step: 
1. Luanch "Settings"->"Sound"->"Manage Tones".
2. Tap "+" icon in upper right.
3. Slect one of the music and tap "Done" button in upper right.
**Now page in "Create Ringtone" page.
4. Tap the headline and "Save" button.
**The "Save" button is OK 

Flame2.0 build:
Gaia-Rev        1ede2666f1e6c1b3fd3b282011caf0cbc59544b0
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/faa64077b0c2
Build-ID        20141119000207
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141119.035230
FW-Date         Wed Nov 19 03:52:41 EST 2014
Bootloader      L1TC00011880

Flame2.1 build:
Gaia-Rev        1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko-Rev      
https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6
Build-ID        20141125001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141125.040617
FW-Date         Tue Nov 25 04:06:28 EST 2014
Bootloader      L1TC00011880

Comment 13

[SandKing]

Attachment: Verify video: verify_1028048.MP4

Comment 14

[SandKing]

Refer to Bug1017416, I check it again, This issue occured.
So change the status
Verify video:"verify_1028048.mp4".

Flame2.0 build
Gaia-Rev        04b42f95e89800a1b8d0aacd96317d3e3dad5731
Gecko-Rev       93efc8b4155f0a4a50eaad19acbb95ec24139e63
Build-ID        20141205050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2
FW-Incremental  1417727171
FW-Date         Fri Dec  5 05:06:39 CST 2014

Flame2.1 build:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141204.034958
FW-Date         Thu Dec  4 03:50:09 EST 2014
Bootloader      L1TC00011880

Comment 15

[SandKing]

Attachment: verify_1028048.MP4

Comment 16

[SandKing]

Comment on attachment 8528943 [details]
Verify video: verify_1028048.MP4

This vidoe is no value, So obsolete it

Comment 17

[SandKing]

Attachment: Bug log: logcat_1708.txt

Comment 18

[Norry.L.F(Leave from Mozilla)]

According to Comment 14, change status back to Resolved Fixed.