1028055 - Sender's email is not displayed In the details page of a received email

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Viorela Ioia [:viorela]]

After we tap an email from the Inbox emails list, sender's email is not displayed in the header, as expected. 'Read' is displayed instead. 

Prerequisities:
Make sure your phone is connected to network
Make sure you have at least one received mail on your Inbox

#STR:
1. Launch Email app
2. Enter your ActiveSync credentials then tap Manual setup
3. Select account type: ActiveSync
4. Enter hostname and username, then tap Next
5. Tap Next
6. Tap Continue to mail
7. Wait for emails to sync
8. Tap on an email you received, to see its details

#Expected results:
Sender's email is displayed in the header of the page

#Actual results:
'Read' is displayed in the header of the page

#ENV:
Device: 
Gaia      82e957160ca017087bd374cd051339e55b641e68
Gecko     https://hg.mozilla.org/mozilla-central/rev/f78e532e8a10
BuildID   20140619040201
Version   33.0a1
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014

The issue is reproducible manually. It is not happening on v2.0
Jenkins report: http://selenium.qa.mtv2.mozilla.com:8080/job/b2g.flame.mozilla-central.ui.smoketest/78/HTML_Report/

Comment 1

[Zac C (:zac)]

It seems like an intended change. Perhaps have a look through the commit history of the E-mail app, see if you can find a commit/bug?

Comment 2

[Viorela Ioia [:viorela]]

Asuth, can you confirm if the change is intended? Thanks!

Comment 3

[Viorela Ioia [:viorela]]

Attachment: screenshot.png

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

The display name of the sender should be displayed if available, otherwise the sender's email address.  Unless the display name was "read", this does seem like a bug.  needinfo-ing :jrburke to handle/triage/etc.

Comment 5

[James Burke [:jrburke]]

Attachment: GitHub pull request

Bug 992473 switched the l10n code to use Mutation Observers for doing localizations, and that code was running after our setting of the title in message_reader's buildHeaderDom, overwriting the name with the localization for the generic card name.

Since we always set that value anyway, the localization for that header is not needed, so I just removed it.

I did a quick nav through the UI to see if this affected other headers, but they seem fine, for instance, the settings screen for an individual account are fine (because it does not have an l10n attribute on that field).

This would not be seen in the 2.0 branch, only on master, which is confirmed by the information the bug reporter provided.

Comment 6

[Zac C (:zac)]

Thanks James and Andrew!

Comment 7

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/5b3faed8692e0b797fb4e628281440df7fa9de12

from pull request:
https://github.com/mozilla-b2g/gaia/pull/20813