1028126 - [Dialer][Call screen] In incoming call the buttons haven't a good alignment

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Paco Rampas [:paco]]

Attachment: on-call-buttons-bottom.png

Comment 1

[Paco Rampas [:paco]]

The pick up button and hang up button should be the same size (50% of width space) and should have a center alignment. But now they have a left alignment and they don't have the correct size. 

This issue happens on devices with 1.5, 2.0 and 2.25 resolution.

Comment 2

[Maria Angeles Oteo (:oteo)]

Reproducing it also in latest 2.0 version on a Peak device

Build info:
peak-v2.0
B-13
Gecko-d6d1155
Gaia-75e1f25
BuildID:20140622211136

Comment 3

[Paco Rampas [:paco]]

Attachment: SPEC.Call_Incomingcall_Expandableareas.png

Comment 4

[Paco Rampas [:paco]]

Attachment: incoming-buttons.png

Comment 5

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: e3b0b8e4a6cf02fe676320e8c8d44b6ffd0fbc88

Comment 7

[Paco Rampas [:paco]]

Comment on attachment 8444261 [details] [review]
patch in github

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): unknown
[User impact] if declined: incorrect UI
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/17ea5a6f290df94e75ef9ef78080c48ba088bb05

Comment 9

[SandKing]

This issue has been verified successfully on Flame2.0&2.1
Verify video:"verify_1028126.mp4".

Flame2.0 build
Gaia-Rev        824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d
Build-ID        20141125040209
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141125.113029
FW-Date         Tue Nov 25 11:30:43 EST 2014
Bootloader      L1TC00011880

Flame2.1 build:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141126.033519
FW-Date         Wed Nov 26 03:35:30 EST 2014
Bootloader      L1TC00011880

Comment 10

[SandKing]

Attachment: Verified video: verify_1028126.mp4