Remove dangerous public destructor of MediaPipeline

RESOLVED FIXED in mozilla35

Status

()

Core
WebRTC: Signaling
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bjacob, Assigned: anujagarwal464)

Tracking

Other Branch
mozilla35
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In bug 1027251 we removed all dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: MediaPipeline
Flags: needinfo?(rjesup)
(Assignee)

Comment 1

4 years ago
Created attachment 8454916 [details] [diff] [review]
bug1028143.diff
Assignee: nobody → anujagarwal464
Attachment #8454916 - Flags: feedback?(bjacob)
(Reporter)

Comment 2

4 years ago
Comment on attachment 8454916 [details] [diff] [review]
bug1028143.diff

Review of attachment 8454916 [details] [diff] [review]:
-----------------------------------------------------------------

Same comment as on bug 1028142. I expected this to be not quite so trivial, but I could of course have been wrong.
Attachment #8454916 - Flags: feedback?(bjacob) → feedback+
(Assignee)

Updated

4 years ago
Attachment #8454916 - Flags: feedback+ → feedback?(continuation)
Comment on attachment 8454916 [details] [diff] [review]
bug1028143.diff

Review of attachment 8454916 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me.  It seems odd that it wasn't fixed before, but this code may have just changed around in the last few months.
Attachment #8454916 - Flags: review?(rjesup)
Attachment #8454916 - Flags: feedback?(continuation)
Attachment #8454916 - Flags: feedback+
Flags: needinfo?(rjesup)

Updated

4 years ago
Attachment #8454916 - Flags: review?(rjesup) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0d8aa5c075e9
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.