1028220 - [v2.1] test_settings_change_language fails on master

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[[:AndreiH]]

From the looks of it, the locator must have changed:

Traceback (most recent call last):
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.9-py2.7.egg/marionette/marionette_test.py", line 170, in run
    testMethod()
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_change_language.py", line 15, in test_change_language_settings
    language_settings = settings.open_language_settings()
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/tests/python/gaia-ui-tests/gaiatest/apps/settings/app.py", line 139, in open_language_settings
    self._tap_menu_item(self._language_menu_item_locator)
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/tests/python/gaia-ui-tests/gaiatest/apps/settings/app.py", line 197, in _tap_menu_item
    menu_item = self._wait_for_menu_item(menu_item_locator)
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/tests/python/gaia-ui-tests/gaiatest/apps/settings/app.py", line 183, in _wait_for_menu_item
    menu_item = self.marionette.find_element(*menu_item_locator)
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.9-py2.7.egg/marionette/marionette.py", line 1213, in find_element
    response = self._send_message('findElement', 'value', **kwargs)
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.9-py2.7.egg/marionette/decorators.py", line 35, in _
    return func(*args, **kwargs)
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.9-py2.7.egg/marionette/marionette.py", line 633, in _send_message
    self._handle_error(response)
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.9-py2.7.egg/marionette/marionette.py", line 664, in _handle_error
    raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
NoSuchElementException: NoSuchElementException: Unable to locate element: .menuItem-languageAndRegion

Comment 1

[[:AndreiH]]

Attachment: screen.png

Comment 2

[[:AndreiH]]

We now have ID "#menuItem-languageAndRegion" instead of Class ".menuItem-languageAndRegion"

Comment 3

[[:AndreiH]]

Attachment: PR https://github.com/mozilla-b2g/gaia/pull/20809

Comment 4

[Zac C (:zac)]

Comment on attachment 8443490 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/20809

It was an intentional change in this commit:
https://github.com/mozilla-b2g/gaia/commit/d0d5c44c427c794a16fdcd2ec8c15c6f121329a4#diff-11

Comment 5

[[:AndreiH]]

Oh sorry about that, I thought that the class was the old change.