1028470 - Long press on images opened from search app displays empty action list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Valentin Tsatskin [:vt]]

Device    Flame
Gaia      c5dd47e3f9e18872961946735fdbc071a1656ac9
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/71b1b4b0850c
BuildID   20140620000202
Version   32.0a2
ro.build.version.incremental=eng.cltbld.20140606.192117
ro.build.date=Fri Jun  6 19:21:29 EDT 2014

# Steps to reproduce

1) Search for "red panda" in search bar on homescreen
2) Press Bing result
3) Pick a result and go to its webpage
4) Longpress image

# Expected Results

An action list opens with option to save image.

# Actual Results

A menu list opens with no results.

Comment 1

[Valentin Tsatskin [:vt]]

https://www.youtube.com/watch?v=qUCdFu2EF-E

Comment 2

[Jason Smith [:jsmith]]

Definitely a regression. QA Wanted to check 1.4.

Comment 3

[Gregor Wagner [:gwagner]]

Aus, is this a dupe?

Comment 4

[Aus Lacroix [:aus]]

This looks new to me. The context menu should have the option to save the image. It may be that it's not an image tag? I'd have to look into more to really say. I'll assign it to myself for investigating.

Comment 5

[Jason Smith [:jsmith]]

Cut & dry blocker for broken UX.

Comment 6

[Cody Roesch [:croesch]]

Have been able to repro this bug on multiple websites where images can be saved. However not all images produce this bug. I've seen the "Save Image" menu list item on most images that can be saved.

This bug repro's on: Flame 2.1 Master, flame 2.0, OpenC 2.1 Master, OpenC 2.0,  

Actual Results: Long tapping on large images on this website that can be made wallpapers, produces this bug.

Environmental Variables:
Device: Flame Master
Build ID: 20140623053744
Gaia: bd5065ced020014df5fd45259fba1ac32d65673b
Gecko: 335b6610fe0c
Version: 33.0a1 (Master)
Firmware Version: v122
--------------------------------------------------
Environmental Variables:
Device: Flame 2.0
Build ID: 20140623051745
Gaia: 84ca0fe0a86d039f6d99cb562f52ef55045dee1d
Gecko: cef223bae66b
Version: 32.0a2 (2.0)
Firmware Version: v122
--------------------------------------------------
Environmental Variables:
Device: Open_C Master
Build ID: 20140623053744
Gaia: bd5065ced020014df5fd45259fba1ac32d65673b
Gecko: 335b6610fe0c
Version: 33.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
--------------------------------------------------
Environmental Variables:
Device: Open_C 2.0
Build ID: 20140623051745
Gaia: 84ca0fe0a86d039f6d99cb562f52ef55045dee1d
Gecko: cef223bae66b
Version: 32.0a2 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
--------------------------------------------------
Environmental Variables:
Device: Buri Master
Build ID: 20140623075647
Gaia: 41cc1de26e4edbe12add0009cdc0bd292f2e94fe
Gecko: 31de1a84b27f
Version: 33.0a1 (Master)
Firmware Version: v1.2device.cfg
--------------------------------------------------
Environmental Variables:
Device: Buri 2.0
Build ID: 20140623051745
Gaia: 84ca0fe0a86d039f6d99cb562f52ef55045dee1d
Gecko: cef223bae66b
Version: 32.0a2 (2.0)
Firmware Version: v1.2device.cfg

--------------------------------------------------
--------------------------------------------------

This bug does NOT repro on: Flame 1.4, OpenC 1.4 or Buri 1.4

Actual Result: No long tap functionality occurs when long tapping on images.

Environmental Variables:
Device: Flame 1.4
Build ID: 20140623000201
Gaia: 3419a1f68aaf64a0688685bce42d4173b6125597
Gecko: 34ecc9af3560
Version: 30.0 (1.4)
Firmware Version: v122
--------------------------------------------
Environmental Variables:
Device: Open_C 1.4
Build ID: 20140623000201
Gaia: 3419a1f68aaf64a0688685bce42d4173b6125597
Gecko: 34ecc9af3560
Version: 30.0 (1.4)
Firmware Version: P821A10V1.0.0B06_LOG_DL
---------------------------------------------
Environmental Variables:
Device: Buri 1.4
Build ID: 20140623105644
Gaia: 127730f3a45f1b35416af294c74902a51ea0a44d
Gecko: d0626e1c4eea
Version: 30.0 (1.4)
Firmware Version: v1.2device.cfg

Comment 7

[Cody Roesch [:croesch]]

Forgot to add that it also occurs on Buri 2.1 Master and Buri 2.0

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug1028470.patch

The handling of the IMG tag, VIDEO and AUDIO tags was not implemented.

Comment 9

[Aus Lacroix [:aus]]

Comment on attachment 8445125 [details] [diff] [review]
bug1028470.patch

I'm pretty sure this isn't right. We're not supposed to be using the System Browser at all in 2.0. It should be routed to the Browser Application.

Comment 10

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

There is a large gap of over a full day between the builds on all branches of both Buri and Flame when this issue occurs.  This lead to a larger than normal pushlog.  

B2g-inbound Regression Window

Last working 
Environmental Variables:
Device: Flame
BuildID: 20140517113002
Gaia: d364c473012b7731688fe0ef4bca92358cee18c5
Gecko: f913ad39fa23
Version: 32.0a1 (Master) 
Firmware Version: v122

First Broken 
Environmental Variables:
Device: Flame
BuildID: 20140519053002
Gaia: 8a2352d5b7be27ec4b1ea18c680ebcd0b6d34348
Gecko: 8508ab79921f
Version: 32.0a1 (Master) 
Firmware Version: v122

Last working gaia / First broken gecko  - Issue does NOT occur
Gaia: d364c473012b7731688fe0ef4bca92358cee18c5
Gecko: 8508ab79921f

First broken gaia / Last working gecko - Issue DOES occur
Gaia: 8a2352d5b7be27ec4b1ea18c680ebcd0b6d34348
Gecko: f913ad39fa23

Gaia Pushlog:  https://github.com/mozilla-b2g/gaia/compare/d364c473012b7731688fe0ef4bca92358cee18c5...8a2352d5b7be27ec4b1ea18c680ebcd0b6d34348

Comment 11

[Dale Harvey (:daleharvey)]

Comment on attachment 8445125 [details] [diff] [review]
bug1028470.patch

Review of attachment 8445125 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, I want an integration test for this, but I have been filling in the missing integration tests while working on related patches, so I can follow up for this, the context menu for wrappers was suprisingly not implemented at all until recently so there was a few missing features

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=016c32bd2ad86664a9c04b464e6cea4d7dd73577

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/62a4c0ae611ff15b721e93fb579aad02c09b4aa5

Gaia-Try is green for all the tests related to this. Seems like we have a new perma-red unrelated to this patch though as I can see it on all Gaia-Try results for everybody...

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/b609f84077294b6b3d864c1ccf6d4ce5f413c865

Comment 15

[Axel Hecht [:Pike]]

(In reply to Jason Smith [:jsmith] from comment #5)
> Cut & dry blocker for broken UX.

Also a cut & dry break of string freeze. Was that the intent?

Comment 17

[sarsenyev]

The issue is fixed on 2.1 and 2.0,

The action list opens with option to save image.


Device: Flame 2.1 KK
BuildID: 20141103001220
Gaia: 027a7de0c95320cea0579bfd1a4ceef3e9038f34
Gecko: ffecb2be228b
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Device: Flame 2.0 KK
BuildID: 20141103000201
Gaia: 7b8df9941700c1f6d6d51ff464f0c8ae32008cd2
Gecko: 82a6ed695964
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0