1028512 - "ASSERTION: lower/upper-roman/alpha should be custom counter style" with transition in SVG

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: lower/upper-roman/alpha should be custom counter style: 'aStyle != NS_STYLE_LIST_STYLE_LOWER_ROMAN && aStyle != NS_STYLE_LIST_STYLE_UPPER_ROMAN && aStyle != NS_STYLE_LIST_STYLE_LOWER_ALPHA && aStyle != NS_STYLE_LIST_STYLE_UPPER_ALPHA', file layout/style/CounterStyleManager.cpp, line 1875

I'm guessing this is a regression from:

changeset:   https://hg.mozilla.org/mozilla-central/rev/bffb0b2f7c2f
user:        Xidorn Quan
date:        Wed Jun 11 21:12:00 2014 -0400
summary:     Bug 966166 - Part 4: Rewrite some builtin counter styles. r=dbaron

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

I don't think it is the regression of my patch. I cannot reproduce this asseration in my local build, which is several days behind the trunk.

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 8443886 [details]
testcase

Fixed the mime type of the testcase; now it should reproduce the assertion.

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

(In reply to Jonathan Kew (:jfkthame) from comment #3)
> Comment on attachment 8443886 [details]
> testcase
> 
> Fixed the mime type of the testcase; now it should reproduce the assertion.

OK, it reproduced. It might be something similar to bug 1016145. We need to call EnsureNonSVGUserAgentStyleSheetsLoaded in some other places to ensure counterstyles.css is loaded.

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch

Comment 6

[Jonathan Kew [:jfkthame]]

Comment on attachment 8443904 [details] [diff] [review]
patch

Review of attachment 8443904 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. We should also land the testcase (add it to layout/svg/crashtests/ and include it in the manifest there), as we clearly don't have adequate test coverage for this particular case.

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch, r=jfkthame

Comment 8

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e0d435b1340e

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e0d435b1340e