1028527 - Back-Button: Cache-Control is ignored after Close Tab has been undone

Status: NEW

(Firefox :: Session Restore, defect)

Description

[Stefan]

User Agent: 

Steps to reproduce:

1. open new tab
2. open web console (ctrl-k)
3. enter testcase url (handed in later)
4. View Image
5. Back
6. Close Tab
7. Undo Close Tab
8. open web console (ctrl-k)
9. View Image
10. Back



Actual results:

5. FF requests url again (OK)
7. (only seen on the server: url is loaded, this is OK)
10. FF does not request url again (FAIL)




Expected results:

10. request url independently of whether the current tab has once been closed

Comment 1

[:Gijs (he/him)]

Tim, is this a session restore issue or does this go in Core / Document Navigation?

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

This might be a dupe of bug 706970, maybe. We load pages from cache when restoring. Not sure why this happens for the given page here as that tries to forbid caching, I thought we wouldn't store that in the first place so there would be nothing to restore.

Comment 3

[:Gijs (he/him)]

(In reply to Tim Taubert [:ttaubert] from comment #2)
> This might be a dupe of bug 706970, maybe. We load pages from cache when
> restoring. Not sure why this happens for the given page here as that tries
> to forbid caching, I thought we wouldn't store that in the first place so
> there would be nothing to restore.

That sounds like a new cache bug, except I don't think that's enabled on 31 (which is where I'm reproducing)...

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

about:cache confirms that we don't cache the site. After loading the page (when undo closing the tab) it seems to however be put in the BFCache. That's where it's served from in step (10).

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Even after reloading the page it's still in the BFCache. Not sure what puts it in there, we'd need to find out.

Comment 6

[Stefan]

I have been asked to review my bugs. This is in UNCONFIRMED state though it has been confirmed.

Comment 7

[Liviu Cirdei]

Hi, 

Tried to reproduce this, but I got confused following the steps you provided (e.g. opened a new tab, opened web console, entered url in the url address, viewed image in browser but no "back" is available). 

Is this issue still reproducing on Firefox 43 and Nightly 46?

If yes, please update the steps to reproduce with some extra info.
Thank you.

Comment 8

[Stefan]

(In reply to Liviu Cirdei from comment #7)
> (e.g. opened a new tab, opened web console, entered url in the url address,
> viewed image in browser but no "back" is available). 

"back" means "pressing the back button". Is there no back button? Or is it inactive?

Comment 9

[Liviu Cirdei]

User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID 	20160106030225

Thanks Stefan. 

I can see the "back" button now. I misunderstood the "view image" step, that's why I did't have a back button.

I also reproduced the issue on Firefox 43 and Nightly 46 and changed the component so people with more experience on this matter to be involved.