Closed Bug 1028568 Opened 11 years ago Closed 11 years ago

[Vertical] Edit mode will-change

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 verified, b2g-v2.1 verified)

Status:
VERIFIED FIXED
Milestone:
2.0 S5 (4july)
Tracking Flags:
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [p=1],[systemsfe])

Attachments

(2 files)

Github pull request
46 bytes, text/x-github-pull-request
kgrandon
: review+
bajaj
: approval-gaia-v2.0+
Details | Review
verified_v2.1.MP4
4.06 MB, video/mp4
Details
Attached file Github pull request —
Splitting off a patch from bug 1023940 so we can more easily track uplift progress - that one seems more like a meta. This has already landed in master: https://github.com/mozilla-b2g/gaia/commit/df882b8ec7d6476ca3e4f91bd1c44a5ac9c12c77
Attachment #8443961 - Flags: review+
Comment on attachment 8443961 [details] [review] Github pull request This is needed for the vertical homescreen.
Attachment #8443961 - Flags: approval-gaia-v2.0?(bbajaj)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #8443961 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
status-b2g-v2.0: --- → affected
status-b2g-v2.1: --- → fixed
Flags: needinfo?(jlorenzo)
Keywords: verifyme
2.0 https://github.com/mozilla-b2g/gaia/commit/43ce80a0df56b56d198f41c151f867f023b885a9 There is not much to verify here besides slightly better drag drop performance.
status-b2g-v2.0: affected → fixed
The drag'n'drop performance seems to be closer to the one we had with the old homescreen, now.
Status: RESOLVED → VERIFIED
status-b2g-v2.0: fixed → verified
Flags: needinfo?(jlorenzo)
Target Milestone: --- → 2.0 S5 (4july)
unable to reproduce this issue because there is no repro steps
QA Whiteboard: [QAnalyst-Triage?][failed-verification]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?][failed-verification] → [QAnalyst-Triage+][QAnalyst-verify-]
Flags: needinfo?(ktucker)
Hi Kevin, Could you help to provide the detailed reproduce steps? Thank you very much!
Flags: needinfo?(kgrandon)
(In reply to Shally from comment #5) > Hi Kevin, > > Could you help to provide the detailed reproduce steps? > > Thank you very much! This is just performance work for edit mode. Assuming edit mode works correctly, this can be verified I suppose.
Flags: needinfo?(kgrandon)
Per Comment 6, I try to do many operations (such as drag down or drag up) in Homescreen edit mode,and the Edit mode works normally (rate:0/5),then clear "verifyme". Please refer video:verified_v2.1.mp4. Flame user 2.1 build: Gaia-Rev 9df43e6e696da43b6a1433283dc5b155987747bc Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/095a46f32cd4 Build-ID 20150129003733 Version 34.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20150129.041104 FW-Date Thu Jan 29 04:11:14 EST 2015 Bootloader L1TC000118D0
status-b2g-v2.1: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: