Closed Bug 1028662 Opened 8 years ago Closed 8 years ago

IonMonkey: Implement PowHalf Recover Instruction

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: layus, Assigned: layus, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Implement PowHalf in js/src/jit/Recover.cpp.
See Bug 1003801 comment 0 for explanation.
Blocks: 1003801
Assignee: nobody → layus.on
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached patch dce-recover-powhalf.patch (obsolete) — Splinter Review
Implement PowHalf Recover Instruction
Attachment #8444095 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8444095 [details] [diff] [review]
dce-recover-powhalf.patch

Review of attachment 8444095 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome :)
Just a last nit.

::: js/src/jsmath.cpp
@@ +662,5 @@
>  #if defined(_MSC_VER)
>  # pragma optimize("g", off)
>  #endif
>  bool
> +js_math_powhalf_handle(JSContext *cx, HandleValue base, MutableHandleValue result)

nit: remove this function, as it is unused.
Attachment #8444095 - Flags: review?(nicolas.b.pierron) → feedback+
Removed dead code (in anticipation of patch review).
Attachment #8444095 - Attachment is obsolete: true
Attachment #8444116 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8444116 [details] [diff] [review]
dce-recover-powhalf.patch

Review of attachment 8444116 [details] [diff] [review]:
-----------------------------------------------------------------

This sounds good :)
Attachment #8444116 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/7d12d632c7a3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.