1028674 - [Collection app] Generated icon shows duplicate apps

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

Smart Collection icons are generated with icons from the 3 first apps in the SC.
Deduped apps aren't taken into account, therefore duplicate apps appear in the generated icon.

Attached screenshot of the following STR:
1. Install "Around Me" SC and open it.
2. There are no pinned apps. Pin the first 2 web results.
3. Swap they're positions (drag and drop)
4. Return to homescreen and observe the SC icon

Expected: The 3 first web results appear in the icon.
Actual: The second result appears twice in the icon.

(Note that the web results in the screenshot would differ depending on device location)

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Screen cast

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Screenshot.jpg

Comment 3

[Amir Nissim (:amirn)]

Attachment: Pull Request

didn't change dedupe.js after all :)

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8455306 [details] [review]
Pull Request

Seems fine to me, thanks!

Comment 5

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/aaf5354

https://tbpl.mozilla.org/?rev=55018022563e4f44c8e0508e20e8d8bb5e8d1bc5&tree=Gaia-Try

Comment 6

[Johan Lorenzo [:jlorenzo]]

Do we want this bug fixed in 2.0?

Comment 7

[Gregor Wagner [:gwagner]]

Amir, do you want to ask for uplift? Seems like a minor bug.

Comment 8

[Amir Nissim (:amirn)]

Comment on attachment 8455306 [details] [review]
Pull Request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Never implemented
[User impact] if declined: Will show duplicate apps in Collection icon
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: deduped icons

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/469ceb19b434a190191ce350e8e8b95ba4ecaa7f

Comment 10

[Elie]

Attachment: VIDEO0106_Compress.MP4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2