1028685 - [Collection app] Edit header obscured

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

When in Collection edit mode, the edit header doesn't appear.
It seems to be obscured by a higher zIndexed header element.

STR:
1. Open any Smart Collection.
2. Enter edit mode (long press a pinned app)

Expected: Edit mode header fades in.
Actual: Not there.

Comment 1

[Jason Smith [:jsmith]]

We need a screenshot of the bug here.

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Screenshot.jpg

In the screenshot it's apparent that the edit mode header isn't visible in edit mode.

Terribly sorry for the poor quality of the screenshot. I'm having trouble taking them from the device.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Ran Ben Aharon (Everything.me) from comment #2)
> Created attachment 8444115 [details]
> Screenshot.jpg
> 
> In the screenshot it's apparent that the edit mode header isn't visible in
> edit mode.
> 
> Terribly sorry for the poor quality of the screenshot. I'm having trouble
> taking them from the device.

Ah I understand the bug now. Are the icons animating when edit mode is active? If there's no visual indicator, then this is a blocker. If there's at least something there, then I don't think it's a blocker.

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Thanks Ran

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8444263 [details]
Github pull request

Yep!

Comment 6

[Ran Ben Aharon [:ranbena] EverythingMe]

Jason, imo this is a blocker, since the home button doesn't work as expected, the "done" button is crucial for UX. See Kevin's comment https://bugzilla.mozilla.org/show_bug.cgi?id=1025963#c15

Comment 7

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/11c5e56bd45134aa0d355bf7de9b9a4a12576763

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/99864fc4a6524f564d0b479d05099259bd061ede

Comment 9

[Elie]

Attachment: VIDEO0104.mp4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2