Closed Bug 1028690 Opened 5 years ago Closed 5 years ago

[Collection app] Pinning/unpinning web results doesn't trigger icon update

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

x86
macOS
defect
Not set

Tracking

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S5 (4july)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: ranbena, Assigned: kgrandon)

References

Details

(Whiteboard: [p=2],[systemsfe])

Attachments

(2 files)

STR:
1. Open any Smart Collection.
2. Pin or unpin a web result.
3. Return to homescreen and observe the SC icon.

Expected: It is updated and reflects the 3 first apps in the Collection.
Actual: The icon stays the same as before.

Notice that changing pinned app's positions does trigger an icon update.
Blocks: vertical-home-next
No longer blocks: vertical-homescreen
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Jason, this is a blocker IMO.
Any change to the Collection content be it pinning or sorting should reflect in the icon.
Flags: needinfo?(jsmith)
Attached file Github pull request
Ran - this one is a bit easier. Have time to take a look? Thanks!
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attachment #8447758 - Flags: review?(ran)
Whiteboard: [p=2],[systemsfe]
Target Milestone: --- → 2.0 S5 (4july)
Comment on attachment 8447758 [details] [review]
Github pull request

Works great.
Attachment #8447758 - Flags: review?(ran) → review+
Ok - blocking for being parity issue.
Blocks: 1015336
No longer blocks: vertical-home-next
blocking-b2g: --- → 2.0+
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-] → [VH-FL-blocking-][VH-FC-blocking+]
Flags: needinfo?(jsmith)
Landed: https://github.com/mozilla-b2g/gaia/commit/348ee5307d7d61a1fa21630835d9824293d6f641
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Attached video VIDEO0105_Compress.MP4
This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.