1028710 - Flickering of views during transition on opening a New Private Tab when tab drawer open and on tab drawer open/close animation

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Frame screenshot #1

Not a new issue.

Currently on New Private Tab there when the tab drawer is open there is a flickering of views in the UI when the tab bar rolls up. This doesn't happen at all with normal tabs.

We need to make sure that there is a proper view shown during the animation and transition.

I see this on my Galaxy S5 and Nexus 5 and other devices.

Video: https://www.youtube.com/watch?v=igEmgbkJ8Tk

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Frame screenshot #2

Comment 2

[Aaron Train [:aaronmt]]

See video of the transition on my Galaxy S5. At the end of the day the transition looks like something is broken as the flicker between views is shown.

Video: https://www.youtube.com/watch?v=igEmgbkJ8Tk

Comment 3

[Aaron Train [:aaronmt]]

Perhaps also emphasized with the New Private Tab placeholder text and graphic taking longer to load and appear. I wonder if that resource loading can be improved?

Comment 4

[Aaron Train [:aaronmt]]

This also is visible on simply opening and closing the tab drawer on the Private Tab pane.

See second video: https://www.youtube.com/watch?v=WvW1A2vvFqo

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Ian - Thoughts

Comment 6

[Ian Barlow (:ibarlow)]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> Ian - Thoughts

What kind of feedback are you asking for? I definitely agree that the views should not flicker when the tab tray opens and closes.

Comment 7

[Lucas Rocha (:lucasr)]

I suspect this is caused by the fact that the LayerView's background doesn't match the private tab's darker color.

Comment 8

[Lucas Rocha (:lucasr)]

Attachment: Set overscroll color based on tab type (r=bnicholson)

Comment 9

[Lucas Rocha (:lucasr)]

Attachment: Init private tab bg color to avoid flickering (r=bnicholson)

Comment 10

[Lucas Rocha (:lucasr)]

Comment on attachment 8449330 [details] [diff] [review]
Set overscroll color based on tab type (r=bnicholson)

Overscroll color can be seen when we open/close the tabs tray. Make it account for the type of tab being selected (normal or private).

Comment 11

[Lucas Rocha (:lucasr)]

Comment on attachment 8449331 [details] [diff] [review]
Init private tab bg color to avoid flickering (r=bnicholson)

Init new private tabs with proper background color.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8449330 [details] [diff] [review]
Set overscroll color based on tab type (r=bnicholson)

Easy enough to steal while Brian is on PTO

Comment 13

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/0a020e033338
https://hg.mozilla.org/integration/fx-team/rev/9e5e9a282e0c

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0a020e033338
https://hg.mozilla.org/mozilla-central/rev/9e5e9a282e0c

Comment 15

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in build:
Firefox for Android 33.0a1 (2014-07-04)

Devices:
Samsung S3 (Android 4.3)
Asus Transformer Pad TF300T (Android 4.2.1)
Motorola Razr (Android 4.0.4)

Comment 16

[Richard Newman [:rnewman]]

This seems related to Bug 1031872, which has a nice slomo video. Lucas, do you have an opinion on that bug?

Comment 17

[Lucas Rocha (:lucasr)]

(In reply to Richard Newman [:rnewman] from comment #16)
> This seems related to Bug 1031872, which has a nice slomo video. Lucas, do
> you have an opinion on that bug?

Seems unrelated. Added a comment there.