need async loader/sandbox api, deprecate old one (e10s)

RESOLVED WONTFIX

Status

Add-on SDK
General
P1
normal
RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: zombie, Unassigned)

Tracking

unspecified

Firefox Tracking Flags

(e10s+)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
the current loader/sandbox api is synchronous, and doesn't abstract the raw sandbox returned from platform, thus making it incompatible with e10s.

this isn't to actually change the implementation to be e10s compatible, just:

1) provide to an async api, 
2) switch to it internally, and 
3) deprecate the old one ASAP

to give addon authors time to switch to the new one.
(Reporter)

Comment 1

4 years ago
> 2) switch to it internally, and 

this might be a bigger thing, and escalate to async content/sandbox and possibly even content/worker, which would warrant a separate bug.

or as they already do most stuff using events, it might all be "just fine".. must investigate.
(In reply to Tomislav Jovanovic [:zombie] from comment #0)
...
> 1) provide to an async api, 


We'll obviously need a JEP for what the new api looks like.
cc'ing dcamp because this could also impact devtools code.
I have some notes from Irving about some loader changes that he wanted for telemetry recordings.  Mainly promise based methods so that one can record when the async loading/unloading process starts and ends accurately.

We should jep this.
Curious about this, is this referring to a new, non-commonJS loader?

Updated

4 years ago
Priority: -- → P1
(Reporter)

Comment 6

4 years ago
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #5)
> Curious about this, is this referring to a new, non-commonJS loader?

no, this is an existing low-level module in loader/sandbox.js that is used for creating a sandbox for loading our content scripts, which in e10s can't be done synchronously, thus the need for the api change.
(Reporter)

Comment 7

4 years ago
Created attachment 8452398 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1539

not actually a patch ready for review, work in progress..
tracking-e10s: --- → +
Blocks: 1075249
(Reporter)

Comment 8

3 years ago
as explained in bug 1058698, this approach wont work because of platform changes. the alternative solution in bug 1058698 has landed, and this should have been closed long ago..
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
(Reporter)

Updated

3 years ago
No longer blocks: 1075249
You need to log in before you can comment on or make changes to this bug.