Closed Bug 1028817 Opened 10 years ago Closed 10 years ago

[Collection app] Wrong box shadow in edit mode

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 verified, b2g-v2.1 verified)

Status:
VERIFIED FIXED
Milestone:
2.0 S5 (4july)
Tracking Flags:
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(3 files)

edit.png
66.08 KB, image/png
Details
Github pull request
190 bytes, text/html
ranbena
: review+
bajaj
: approval-gaia-v2.0+
Details
VIDEO0132.mp4
1.99 MB, video/mp4
Details
Attached image edit.png — 
      No description provided.
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Blocks: 1015336
Whiteboard: [systemsfe]
Summary: Bug 1028685 - [Collection app] Wrong box shadow in edit mode → [Collection app] Wrong box shadow in edit mode
Attached file Github pull request — 
Thanks again Ran
Attachment #8444288 - Flags: review?(ran)
Comment on attachment 8444288 [details]
Github pull request

Coolness.
Didn't even know what that title bg was :)
Attachment #8444288 - Flags: review?(ran) → review+
Thank you for your time, I saw the issue when I fixed the edit header :)
UX - is this a blocker for the visual refresh?
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?]
Flags: needinfo?(firefoxos-ux-bugzilla)
Flagging Vicky for final say here but initial response is "probably not a blocker."
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(vpg)
Looks like we have an R+, so landing: https://github.com/mozilla-b2g/gaia/commit/774fa10dc668e02c6952e5c5838bdec6c7cfc58d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8444288 [details]
Github pull request

This is needed for the vertical homescreen.
Attachment #8444288 - Flags: approval-gaia-v2.0?(bbajaj)
Target Milestone: --- → 2.0 S5 (4july)
Attachment #8444288 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
This is not my area, homescreen is being worked by Peter La.
Flags: needinfo?(vpg)
Attached video VIDEO0132.mp4 — 
This issue has been successfully verified on Flame 2.0:
Gaia-Rev        3aa0797c111a40e36f722722309668de3d469181
Gecko-Rev       93efc8b4155f0a4a50eaad19acbb95ec24139e63
Build-ID        20141204050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2
Status: RESOLVED → VERIFIED
status-b2g-v2.0: fixed → verified
status-b2g-v2.1: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: