1028832 - Customization Mode: Bookmarks item animates text when getting picked up from the menu panel

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[u428464]

I've noticed a couple of animation issues in customization mode :

-New e10s window and bookmarks toolbar items have no animation at all. For e10s it's maybe due to the fact it hasn't a proper icon (also see http://f.cl.ly/items/1M110D0q203W141r2v3E/Image%202014-05-05%20at%2012.41.50%20PM.png )
-Bookmarks widget also animates the text when it's taken from the menu panel (which isn't the case for all other widgets).
-Loop item is also buggy, but implementation is not finished

Comment 1

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

The e10s icon is currently just a transformed »New Window« icon which is why it doesn't animate properly. Given that it will never ship past Nightly (when e10s is finished, every window will be e10s), I think our time is better used on fixing other issues.

The issue with loop also seems to be rooted in how unfinished that project still is.

This leaves the issue with the Bookmarks widget. I'm updating the bug description accordingly.

Comment 2

[:Gijs (he/him)]

(In reply to Philipp Sackl [:phlsa] from comment #1)
> The e10s icon is currently just a transformed »New Window« icon which is why
> it doesn't animate properly. Given that it will never ship past Nightly
> (when e10s is finished, every window will be e10s), I think our time is
> better used on fixing other issues.
> 
> The issue with loop also seems to be rooted in how unfinished that project
> still is.
> 
> This leaves the issue with the Bookmarks widget. I'm updating the bug
> description accordingly.

I'm pretty sure the bookmarks thing is already filed...

Comment 3

[u428464]

Even with the clarification there is still two issues. The one with the bookmarks widget text and the one with the bookmarks toolbar item which isn't animated at all.

Comment 4

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Guillaume C. [:ge3k0s] from comment #3)
> Even with the clarification there is still two issues. The one with the
> bookmarks widget text and the one with the bookmarks toolbar item which
> isn't animated at all.

Oh sorry, I read over that part in you original bug report :)
The bookmarks toolbar items issue seems to be very different from the bookmark star issue. Could you file a separate bug for the former? Thanks!

Comment 5

[u428464]

Can this be nominated for the backlog ?

Comment 6

[u428464]

It's been fixed by Photon.