1028877 - [Tarako]Video file is still opening when camera stop, that would cause a "usb storage" bug

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Zhou Lianxiang]

1 When camera is recording to a video file, the file is opened by both camera app(373) and b2g app(85).
$ adb shell lsof
b2g          85       root  112       ???                ???       ???        ??? /mnt/sdcard/DCIM/100MZLLA/VID_0046.3gp
b2g         373    app_373   42       ???                ???       ???        ??? /mnt/sdcard/DCIM/100MZLLA/VID_0046.3gp
b2g         373    app_373   43       ???                ???       ???        ??? /mnt/sdcard/DCIM/100MZLLA/VID_0046.3gp
b2g         373    app_373   44       ???                ???       ???        ??? /mnt/sdcard/DCIM/100MZLLA/VID_0046.3gp

2 When camera stop record, the video file is still opening. But only one for each application.
$ adb shell lsof
b2g          85       root  112       ???                ???       ???        ??? /mnt/sdcard/DCIM/100MZLLA/VID_0046.3gp
b2g         373    app_373   42       ???                ???       ???        ??? /mnt/sdcard/DCIM/100MZLLA/VID_0046.3gp

3 We close the camera application, the video file is still opening by b2g app(85).
$ adb shell lsof
b2g          85       root  112       ???                ???       ???        ??? /mnt/sdcard/DCIM/100MZLLA/VID_0046.3gp

4 If we take more record, each record left a file open by b2g app(85), and one for camera app if the camera application is still running.

5 This will cause a bug when we try to enable usb storage.
I/AutoMounter(   85): UpdateState: umsAvail:1 umsEnabled:1 mode:1 usbCablePluggedIn:1 tryToShare:1
I/AutoMounter(   85): UpdateState: Volume extsdcard is Mounted and inserted @ /mnt/sdcard gen 1 locked 0 sharing y
W/AutoMounter(   85): The following files are open under '/mnt/sdcard'
W/AutoMounter(   85):   PID: 85 file: '/mnt/sdcard/DCIM/100MZLLA/VID_0027.3gp' app: '' comm: 'b2g' exe: '/system/b2g/b2g'
W/AutoMounter(   85):   PID: 85 file: '/mnt/sdcard/DCIM/100MZLLA/VID_0019.3gp' app: '' comm: 'b2g' exe: '/system/b2g/b2g'
W/AutoMounter(   85):   PID: 85 file: '/mnt/sdcard/DCIM/100MZLLA/VID_0018.3gp' app: '' comm: 'b2g' exe: '/system/b2g/b2g'
W/AutoMounter(   85): UpdateState: Mounted volume extsdcard has open files, not sharing or formatting

6 After the left video file is opening, we enable "settings->USB storage", and then insert the usb cable, the AutoMounter process will run but fail for the opening file. And all applications can not access the sdcard. The AutoMounter can not recover unless we kill the b2g application. There is a deadlock in the AutoMounter progress.

7 No bug in ffos1.4. The camera app and b2g app close the video file timely when record is stopped.

Comment 1

[Dave Hylands [:dhylands]]

As part of fixing bug 910498, I also filed and fixed several other bugs.

Bug 977372 and bug 977373 were both handle leaks which may be related to this. It looks like these were both fixed in 1.4 and not backported to 1.3T.

It looks like 910498 was backported to 1.3T, so I think that 977372 and 977373 also need to be backported.

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-1028877_v1.3t.diff

After backport patch on bug 977372 and 977373 to v1.3t, the problem was fixed.

Comment 3

[Dave Hylands [:dhylands]]

Comment on attachment 8445044 [details] [diff] [review]
bug-1028877_v1.3t.diff

Review of attachment 8445044 [details] [diff] [review]:
-----------------------------------------------------------------

For trackability, please request approval for uplift of bugs 977372 and bug 977373 to 1.3t.

If branch specific versions of the patches are required, then they should be attached to those bugs, and not this bug.

Comment 4

[Hema Koka [:hema]]

Blocking because the scenario leads to inaccessible sdcard/deadlock in automounter and there is no recovery unless you kill the b2g application.

Comment 5

[[:fabrice] Fabrice Desré]

I gave approval on both bugs. If someone could do the uplifts...

Comment 6

[Dave Hylands [:dhylands]]

It looks like the patches for bug 977372 and bug 977373 were both uplifted to 1.3t gecko.

I wasn't able to test these (I don't have a tarako), so I'd appreciate hearing about whether they work or not, and if they do, then I can go ahead and close this bug.

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

I verified with today build on my tarako, I can't reproduce at all.

Comment 8

[James Zhang (Spreadtrum)]

(In reply to Kai-Zhen Li from comment #7)
> I verified with today build on my tarako, I can't reproduce at all.