Closed Bug 1028899 Opened 11 years ago Closed 11 years ago

Graceful Shutdown

Categories

(Hello (Loop) :: Server, defect)

Product:
Hello (Loop)
Component:
Server
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: tarek, Assigned: alexis+bugs)

Details

(Whiteboard: [qa+])

The Loop Server should give a chance for the current connections to finish before its closed. We should also make sure we don't accept any new connection during the graceful period. See http://glynnbird.tumblr.com/post/54739664725/graceful-server-shutdown-with-node-js-and-express for an example I guess that could also apply to msisdn
Circus will send a SIGTERM and a SIGKILL after 30 seconds, So loop graceful period should be < 30s. If it's not enough, we should ask Benson to raise that time
Whiteboard: [qa+]
https://github.com/mozilla-services/loop-server/commit/7eeb3c605f36eb42bc30f6d78de82a1fa4939ba0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Verified in code and unit tests.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.