1028903 - Improve anti-self-xss warning message

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect)

Description

[Joe Walker [:jwalker]]

See bug 994134 comment 78 and 79.

Comment 1

[Manish Goregaokar [:manishearth]]

I'll do this today or tomorrow.

Comment 2

[Manish Goregaokar [:manishearth]]

Attachment: Add separate message for scratchpad

I didn't add the bolding (It would require either putting HTML in the l10n file, or having a couple more strings), but if you want I can add it.

Comment 3

[Joe Walker [:jwalker]]

Comment on attachment 8469865 [details] [diff] [review]
Add separate message for scratchpad

Review of attachment 8469865 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/webconsole/utils.js
@@ +561,5 @@
>     * @param nsIDOMElement notificationBox
>     * @returns A function to be added as a handler to 'paste' and 'drop' events on the input field
>     */
> +  pasteHandlerGen: function WCU_pasteHandlerGen(inputField, notificationBox, l10nURL) {
> +    let l10nBundle = new WebConsoleUtils.l10n(l10nURL);

Rather than construct a new WebConsoleUtils.l10n object here, please could you pass in 'msg'.

webconsole.js already has a module variable for the Strings object, but we'll need to add one to scratchpad, I think.

It's a bit more code duplication, but the l10n objects can be fairly heavyweight, so I think it's justified.

Comment 4

[Manish Goregaokar [:manishearth]]

Attachment: Patch, strings passed to handler generator

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b44ed005d30b

Comment 5

[Joe Walker [:jwalker]]

Comment on attachment 8472972 [details] [diff] [review]
Patch, strings passed to handler generator

Review of attachment 8472972 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Manish

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/17485987eef9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/17485987eef9