1029139 - Remove dangerous public destructor of nsDOMCSSValueList

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: nsDOMCSSValueList

Comment 1

[Nathan Froyd [:froydnj]]

Anuj, does this bug look like something you'd be interested in?

Comment 2

[Andrew McCreight [:mccr8] (PTO until 12-2)]

Sorry again, this got swept up in my layout style cleanup.

Comment 3

[Anuj Agarwal [:anujagarwal464]]

@Andrew, np :)

Comment 4

[Andrew McCreight [:mccr8] (PTO until 12-2)]

Attachment: Make the destructor of nsDOMCSSValueList private.

try run: https://tbpl.mozilla.org/?tree=Try&rev=ff1ece740d55

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8446043 [details] [diff] [review]
Make the destructor of nsDOMCSSValueList private.

r=me

Comment 6

[Andrew McCreight [:mccr8] (PTO until 12-2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/06101c617d6a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/06101c617d6a