Closed
Bug 1029140
Opened 10 years ago
Closed 10 years ago
Remove dangerous public destructor of nsROCSSPrimitiveValue
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: bjacob, Assigned: mccr8)
References
Details
Attachments
(1 file)
4.93 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist. One of them is: nsROCSSPrimitiveValue
Comment 1•10 years ago
|
||
Anuj, does this bug look like something you'd be interested in?
Flags: needinfo?(anujagarwal464)
Assignee | ||
Comment 2•10 years ago
|
||
I came across this code and just fixed it.
Assignee: nobody → continuation
Flags: needinfo?(anujagarwal464)
Assignee | ||
Comment 3•10 years ago
|
||
try run: https://tbpl.mozilla.org/?tree=Try&rev=ff1ece740d55
Attachment #8446041 -
Flags: review?(bzbarsky)
Comment 4•10 years ago
|
||
Comment on attachment 8446041 [details] [diff] [review] Make the destructor of nsROCSSPrimitiveValue private. r=me
Attachment #8446041 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b75f3c5528e6
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b75f3c5528e6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•