Closed Bug 1029140 Opened 6 years ago Closed 6 years ago

Remove dangerous public destructor of nsROCSSPrimitiveValue

Categories

(Core :: Layout, defect)

Other Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: bjacob, Assigned: mccr8)

References

Details

Attachments

(1 file)

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: nsROCSSPrimitiveValue
Anuj, does this bug look like something you'd be interested in?
Flags: needinfo?(anujagarwal464)
I came across this code and just fixed it.
Assignee: nobody → continuation
Flags: needinfo?(anujagarwal464)
Comment on attachment 8446041 [details] [diff] [review]
Make the destructor of nsROCSSPrimitiveValue private.

r=me
Attachment #8446041 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/b75f3c5528e6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
No longer depends on: 1028588
You need to log in before you can comment on or make changes to this bug.