1029163 - https proxying instability

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

A few problems have been found with https proxying resulting in the usual mishmash of hung sockets and corrupt data on uploads :)

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: part 2 tlsproxy incomplete upload flushes need to be rescheduled r= hurley

Comment 2

[Patrick McManus [:mcmanus]]

Attachment: part 1 nsPipe can turn failures into OK, consider that in the tlsproxy code

Comment 3

[Patrick McManus [:mcmanus]]

Attachment: part 3 tunnel https/h1 over h2 could duplicate bytes in upload and corrupt data

Comment 4

[Patrick McManus [:mcmanus]]

https://tbpl.mozilla.org/?tree=Try&rev=c3aa023be67b

Comment 5

[Patrick McManus [:mcmanus]]

I actually exported the wrong rev of part 1 - this is the interdiff


diff --git a/netwerk/protocol/http/TunnelUtils.cpp b/netwerk/protocol/http/TunnelUtils.cpp
index 18ce103..4fcae9a 100644
--- a/netwerk/protocol/http/TunnelUtils.cpp
+++ b/netwerk/protocol/http/TunnelUtils.cpp
@@ -344,17 +344,17 @@ TLSFilterTransaction::WriteSegments(nsAHttpSegmentWriter *aWriter,
   LOG(("TLSFilterTransaction::WriteSegments %p max=%d\n", this, aCount));
 
   if (!mTransaction) {
     return NS_ERROR_UNEXPECTED;
   }
 
   mSegmentWriter = aWriter;
   nsresult rv = mTransaction->WriteSegments(this, aCount, outCountWritten);
-  if (NS_SUCCEEDED(rv) && NS_FAILED(mFilterReadCode) && !outCountWritten) {
+  if (NS_SUCCEEDED(rv) && NS_FAILED(mFilterReadCode) && !(*outCountWritten)) {
     // nsPipe turns failures into silent OK.. undo that!
     rv = mFilterReadCode;
   }
   LOG(("TLSFilterTransaction %p called trans->WriteSegments rv=%x %d\n",
        this, rv, *outCountWritten));
   return rv;
 }

Comment 6

[Patrick McManus [:mcmanus]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/1f5625271af6
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/650a94cde2d8
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/9cdded2baf00

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1f5625271af6
https://hg.mozilla.org/mozilla-central/rev/650a94cde2d8
https://hg.mozilla.org/mozilla-central/rev/9cdded2baf00