Closed Bug 1029163 Opened 5 years ago Closed 5 years ago

https proxying instability

Categories

(Core :: Networking: HTTP, defect)

33 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: mcmanus, Assigned: mcmanus)

References

Details

Attachments

(3 files)

A few problems have been found with https proxying resulting in the usual mishmash of hung sockets and corrupt data on uploads :)
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attachment #8444728 - Flags: review?(hurley)
Attachment #8444724 - Flags: review?(hurley)
Attachment #8444729 - Flags: review?(hurley)
Attachment #8444728 - Flags: review?(hurley) → review+
Attachment #8444724 - Flags: review?(hurley) → review+
Attachment #8444729 - Flags: review?(hurley) → review+
I actually exported the wrong rev of part 1 - this is the interdiff


diff --git a/netwerk/protocol/http/TunnelUtils.cpp b/netwerk/protocol/http/TunnelUtils.cpp
index 18ce103..4fcae9a 100644
--- a/netwerk/protocol/http/TunnelUtils.cpp
+++ b/netwerk/protocol/http/TunnelUtils.cpp
@@ -344,17 +344,17 @@ TLSFilterTransaction::WriteSegments(nsAHttpSegmentWriter *aWriter,
   LOG(("TLSFilterTransaction::WriteSegments %p max=%d\n", this, aCount));
 
   if (!mTransaction) {
     return NS_ERROR_UNEXPECTED;
   }
 
   mSegmentWriter = aWriter;
   nsresult rv = mTransaction->WriteSegments(this, aCount, outCountWritten);
-  if (NS_SUCCEEDED(rv) && NS_FAILED(mFilterReadCode) && !outCountWritten) {
+  if (NS_SUCCEEDED(rv) && NS_FAILED(mFilterReadCode) && !(*outCountWritten)) {
     // nsPipe turns failures into silent OK.. undo that!
     rv = mFilterReadCode;
   }
   LOG(("TLSFilterTransaction %p called trans->WriteSegments rv=%x %d\n",
        this, rv, *outCountWritten));
   return rv;
 }
You need to log in before you can comment on or make changes to this bug.