102918 - Mail dialog for making us the default comes up before the mail window

Status: VERIFIED FIXED

(MailNews Core :: Simple MAPI, defect, P2)

Description

[Scott MacGregor]

using the test builds hosted by mozilla:

If I launch mail for the first time w/ simple mapi installed, the profile
manager comes up. I select my profile. Then I get dialog asking me about making
mozilla mail the default mail client (for mapi). After dismissing this dialog
the mail window then shows up. This is very confusing to me if I were a new
user. The dialog box should be coming up on top of the mail window. i.e. the
mail window comes up, the user can see that mail has been launched here. Then
the modal dialog comes up asking them to make use the default mail client. 

I would note that the browser dialog for making us the default browser used to
work this way. that is, it came up once the first browser window was visible to
the user. 

I'll post a screen shot which will illustrate the strange look.

Comment 1

[Scott MacGregor]

Nominating for the branch. I suspect Jennifer might have some UE concerns. We
shouldn't be putting up this mail dialog without a mail window underneath it.
Starting up the app and just seeing this dialog without anything underneath it
looks out of place to me. IMHO.

Comment 2

[Scott MacGregor]

Attachment: jpg showing the naked dialog that comes up before the mail 3 pane

Comment 3

[Tiantian Kong]

Reassign to Srilatha.

Comment 4

[jglick]

I agree with mscott, that seeing this dialog in the context of the Mail app 
behind it, will help users understand why they are seeing this dialog.

Comment 5

[(not reading, please use [e-mail] instead)]

is windows xp integration on the branch?  if so, I think one thing to do while 
pursuing this fix is to address #102560

I'll work with srilatha on this.

Comment 6

[(not reading, please use [e-mail] instead)]

ok, I got a branch build and I can reproduce the bug.

investigating a fix...

Comment 7

[(not reading, please use [e-mail] instead)]

ok, testing a potential fix.

I've put the call to showMailIntegrationDialog() on a instant timer, so it will 
get executed *after* the window loads.

I've also extended the nsIMapiRegistry interface to take a nsIDOMWindow, so 
that we can pass the parent window (to root the confirm dialog).

here comes a patch.

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: a fix

Comment 9

[(not reading, please use [e-mail] instead)]

taking from srilatha, since I've got the fix.

this fix works if you launch addrbook, compose or 3 pane.

Comment 10

[Srilatha Moturi]

looks good r=srilatha

Comment 11

[David :Bienvenu]

Comment on attachment 52610 [details] [diff] [review]
a fix

sr=bienvenu

Comment 12

[(not reading, please use [e-mail] instead)]

this patch also fixes a bug with the account wizard and new profiles.

when you launch mail for the first time, you'll get the account wizard, and 
when you close the wizard, then you'll get the integration confirm dialog.

I can't land this on the trunk because the mapi code is not on the trunk yet.

once this land on the branch, I'll re-assign to srilatha, so she can land it on 
the trunk.

Comment 13

[Jaime Rodriguez, Jr.]

This sounds like an interesitng bug. Can we talk about it, in the PDT tomorrow?

Comment 14

[Jaime Rodriguez, Jr.]

pls check this into the 094 branch - PDT+

Comment 15

[(not reading, please use [e-mail] instead)]

fixed on the branch, marking fixed since this is branch only.

srilatha, please add this to your list of patches to bring over when mapi lands 
on the trunk.

Comment 16

[Trix Supremo]

verified on 2001-10-15-05-0.9.4

Comment 17

[Rajiv Dayal]

The patch  (attachment id=52610) needs to be landed on the trunk. Seth can u
please sr this for the trunk along with MAPI trunk landing ?
thanks, - Rajiv.

Comment 18

[Michael Wardle]

I'm seeing something similar to this in 0.9.8 (filed bug 127762).  It would be
nice if somebody could take a look to see if it's a regression.