[User Story] Add "share" to the context menu for <img> and <a>

RESOLVED FIXED in 2.0 S5 (4july)

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: sicking, Assigned: daleharvey)

Tracking

unspecified
2.0 S5 (4july)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [ucid:System219, ft:systemsfe])

User Story

As a user, I want to be able to share content contained within <img> and <a> tags to make it easier to make content on websites/apps available to other apps.

Attachments

(1 attachment)

We should add "share" to the default context menu for <img> and <a>. And maybe also to <input type=image>, though that's used rarely enough that I'm not sure that it matters these days.

We should do this both in webpages and in apps, so I'll mark this as depending on bug 1029336
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
(Assignee)

Updated

5 years ago
Assignee: nobody → dale
Francis, what are your thoughts on UX here?  
This is to be able to do things like share an image within an app to another app.  
Is it safe to assume that this would be through the long press?
blocking-b2g: --- → backlog
User Story: (updated)
Flags: needinfo?(fdjabri)
Whiteboard: [ucid:System219, ft:systemsfe]
Summary: Add "share" to the context menu for <img> and <a> → [User Story] Add "share" to the context menu for <img> and <a>
(Assignee)

Comment 2

5 years ago
The context menu is invoked via long press, the share menuitem already exists on links, this will just add it to images
Yes, we should enable a long press on image to bring up the context menu. This is specified in the latest rocket bar spec at: https://mozilla.box.com/s/2tix674298wtc4e4hewh
Flags: needinfo?(fdjabri)
(Assignee)

Comment 4

5 years ago
Created attachment 8448405 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/21202

Share already exists on links, just needed added to media as in the specs
Attachment #8448405 - Flags: review?(kgrandon)
Comment on attachment 8448405 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/21202

Seems fine to me, thanks for the test.
Attachment #8448405 - Flags: review?(kgrandon) → review+
(Assignee)

Comment 6

5 years ago
Cheers

https://github.com/mozilla-b2g/gaia/commit/505008f17b038f1da3aab332377564f6c47b6cef
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S5 (4july)
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.