1029436 - Desktop Client needs in-call display of default avatar when receiving or sending audio-only streams

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Comment 1

[:shell escalante]

plumbing = ability to pass URL representing user avatar.  accountless will never have avitar.  holding off avatar to 34 to avoid wierd UI.

Comment 2

[Romain Testard [:RT]]

Why is this one being moved to FF35? I think we need it in FF34 for a better visual rendering - we won't have avatars in FF34 although we should use a default avatar when the following scenarios as per https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#call-active:
* I receive audio only but I send audio+video
* I send audio+video but I receive audio only

Comment 3

[Maire Reavy [:mreavy]]

There isn't specific to FxA

Comment 4

[Darrin Henein [:darrin]]

Agree, this would make it clear in the case of mixed media calls that nothing is broken (i.e. showing the default avatar instead of a black box).

Comment 5

[Maire Reavy [:mreavy]]

Mark -- We're trying to finalize what bugs we're committing to for Fx34.  How complicated would it be to do this bug during the Fx34 Nightly cycle (after bug 990678 is done)?

Comment 6

[Mark Banner (:standard8)]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #5)
> Mark -- We're trying to finalize what bugs we're committing to for Fx34. 
> How complicated would it be to do this bug during the Fx34 Nightly cycle
> (after bug 990678 is done)?

My biggest concern is how any avatar image would interact with the sdk, though I can think of potential ways around it. It looks like Andrei has taken on this bug, so maybe he can do a quick PoC and report back.

Comment 7

[Andrei Oprea [mention me on [e-mail]]]

(In reply to Mark Banner (:standard8) from comment #6)
> (In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #5)
> > Mark -- We're trying to finalize what bugs we're committing to for Fx34. 
> > How complicated would it be to do this bug during the Fx34 Nightly cycle
> > (after bug 990678 is done)?
> 
> My biggest concern is how any avatar image would interact with the sdk,
> though I can think of potential ways around it. It looks like Andrei has
> taken on this bug, so maybe he can do a quick PoC and report back.

I looked into it today [0] and the only complexity comes from the fact that the conversation view is shared between desktop and standalone (and there are a lot of divs with absolute positioning) I'll switch to this bug after default answering mode on desktop bug 1042060

[0] http://i.imgur.com/rQtii10.png

Comment 8

[Andrei Oprea [mention me on [e-mail]]]

What is our default avatar in this case ?

Comment 9

[Sevaan Franks [:sevaan]]

No avatar exists at the moment. I've created a bug to address this: Bug 1053273

Comment 10

[Adam Roach [:abr]]

Attachment: Temporary avatar

Comment 11

[Sevaan Franks [:sevaan]]

Comment on attachment 8472475 [details]
Temporary avatar

Thanks, :abr. 

Do you think you could upload a version with an invisible background, so the image doesn't skew if the aspect ratio doesn't match? And a blank background that we can put behind it?

Much appreciated!

Comment 12

[Andrei Oprea [mention me on [e-mail]]]

How should the UI look (especially on standalone) when you are receiving audio only and sending audio + video.

Also there is an audio only view where desktop is collapsed (not sure about standalone there).

Comment 13

[Maire Reavy [:mreavy]]

Andrei -- Are you blocked waiting on a reply from Darrin?

Comment 14

[Andrei Oprea [mention me on [e-mail]]]

After talking to Dan my understanding was that we will put off in-call avatars until landing the visual spike just to avoid having to deal with rebase conflicts twice. Let me know if this is a priority + we can talk more in today's meeting.

Comment 15

[Darrin Henein [:darrin]]

It sounds like you and Dan sorted this out -- do you still need clarification from me?

Comment 16

[Andrei Oprea [mention me on [e-mail]]]

(In reply to Darrin Henein [:darrin] from comment #15)
> It sounds like you and Dan sorted this out -- do you still need
> clarification from me?

Yes. The standalone spec [0] only shows video2video calls and the desktop spec [1] shows just audio-audio calls. Not sure what to do about mixed cases (audio on one end video on the other) for standalone and desktop. Thanks!

[0] https://people.mozilla.org/~dhenein/labs/loop-link-spec/#video-call
[1] https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#call-active-audio

Comment 17

[Darrin Henein [:darrin]]

For mixed calls, the UI should be the same as video/video calls, with the audio-sending party (either you or them) replaced with the avatar (user's or default).

Comment 18

[Andrei Oprea [mention me on [e-mail]]]

The avatar looks really bad if there is no transparent background. It uses a gradient background so I cannot fill the background with a specific color and have to stretch the image (especially on standalone) to unnatural dimensions.

Comment 19

[Mark Banner (:standard8)]

This was actually fixed in bug 1048938 with the temporary image. Hence resolving.

I've filed bug 1066076 to manage updating to the proper UX image once it is defined.

We don't want to uplift this until we get the correct image.

Comment 20

[u279076]

Paul, can you please test this in the latest Nightly?

Comment 21

[Paul Silaghi, QA [:pauly]]

The client's avatar seems to be very dark in comparison with the link clicker's
http://i.imgur.com/8ED0sNr.png?1
Thoughts ?

Comment 22

[Andrei Oprea [mention me on [e-mail]]]

(In reply to Paul Silaghi, QA [:pauly] from comment #21)
> The client's avatar seems to be very dark in comparison with the link
> clicker's
> http://i.imgur.com/8ED0sNr.png?1
> Thoughts ?

That does not look right. I'll try to see why.

Comment 23

[u279076]

(In reply to Andrei Oprea [:andreio] from comment #22)
> That does not look right. I'll try to see why.

I tried flagging Andrei but the account seems to be disabled. Mark, can you check into this or find someone who might be able to look into what Paul reported above?

Comment 24

[Mark Banner (:standard8)]

Given where we are, I suggest we get a new bug on comment 21 with the image attached, then we can ask UX for their opinion/how much they want it to change.

Comment 25

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 35b3 considering bug 1103930.