1029478 - Remove dangerous public destructor of TransportFlow

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 1028588 we removed all dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: TransportFlow

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Remove dangerous public destructor of TransportFlow.

try: https://tbpl.mozilla.org/?tree=Try&rev=daa327c18c40

Comment 2

[Adam Roach [:abr]]

Comment on attachment 8464351 [details] [diff] [review]
Remove dangerous public destructor of TransportFlow.

Review of attachment 8464351 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable. One small nit...

::: media/mtransport/transportflow.h
@@ +65,1 @@
>    ~TransportFlow();

I'd prefer if we moved this down to the existing "private" section.

Comment 3

[Andrew McCreight [:mccr8]]

> I'd prefer if we moved this down to the existing "private" section.
Done.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9cdb0d2dcf5d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9cdb0d2dcf5d