1029500 - bug.attachments shouldn't include attachment data by default

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Kohei Yoshino]

+++ This bug was initially created as a clone of Bug #1027025 +++

I just noticed my BzAPI app downloaded 6 MB of data at startup while testing the compat API. Looks like the compat API's bug method returns attachments with the data and encoding:

https://api-dev.bugzilla.mozilla.org/latest/bug?id=1027037&include_fields=id%2Cattachments
https://bugzilla.mozilla.org/bzapi/bug?id=1027037&include_fields=id%2Cattachments

The extra data won't be a compatibility issue, but to reduce bandwidth, the data shouldn't be returned unless we expressly retrieve it.

https://api-dev.bugzilla.mozilla.org/latest/bug?id=1027037&include_fields=id%2Cattachments&attachmentdata=1
https://api-dev.bugzilla.mozilla.org/latest/bug?id=1027037&include_fields=id%2Cattachments%2Cattachments.data%2Cattachments.encoding

https://wiki.mozilla.org/Bugzilla:REST_API:Methods#Retrieve_attachment_.28.2Fattachment.2F.3Cid.3E_GET.29

Comment 1

[Kohei Yoshino]

ping?

Comment 2

[:glob ✱]

Attachment: 1029500_1.patch

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8452399 [details] [diff] [review]
1029500_1.patch

Review of attachment 8452399 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 4

[:glob ✱]

it's a shame we have to grab the attachment data from the db only to drop it later, but that's fodder for another bug.

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   4c9f4e7..3deb100  master -> master