Closed Bug 1029524 Opened 8 years ago Closed 2 years ago

Search Engines added from Page Menu have smaller favicons

Categories

(Firefox for Android Graveyard :: Favicon Handling, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox30 affected, firefox31 affected, firefox32 affected, firefox33 affected, firefox35 affected, firefox36 affected, firefox37 affected, firefox38 affected, firefox39 affected, firefox40 affected)

RESOLVED INCOMPLETE
Tracking Status
firefox30 --- affected
firefox31 --- affected
firefox32 --- affected
firefox33 --- affected
firefox35 --- affected
firefox36 --- affected
firefox37 --- affected
firefox38 --- affected
firefox39 --- affected
firefox40 --- affected

People

(Reporter: ioana.chiorean, Unassigned)

References

Details

Attachments

(2 files)

Attached image Screenshot
OS: Android 4.4.4 and 4.1.2
Devices: Alcatel One Touch, Nexus 4

Steps:
1. Go to bugzilla.mozilla.org
2. Tap the menu -> Page -> Add a Search Engine
3. Go to Settings -> Customization -> Search 

Expected Results:
- Favicons should be of same size as the already added ones

Actual Results:
- The favicons of the Search Engines added through Page Menu are smaller

Note:
- Reproducible also on Gingerbread 2.3
- Reproducible with all mozilla pages: MDN, Marketplace, wiki, Sumo Etc
Chris, do you know what's going on here?
Flags: needinfo?(chriskitching)
I think this is due to a discrepancy between the resolutions of bundled favicons and favicons downloaded from the web.
All the initially-present search engines have a favicon bundled of decent(ish) resolution. When you add a new one it uses the icon downloaded from the internet which, in the case of bugzilla.mozilla.org, is tiny.

This works both ways. Check out what happens when I go to amazon.co.uk and add it again (even though it's bundled):
https://www.dropbox.com/s/20asm7pwi06rp6k/amazon.png

The bundled icon is of *lower* resolution than the downloaded one.

There's two existing bugs that work together to create this problem:

The general problem of "We can't find an icon to represent this site that's of a good enough size" is Bug 826400. A fairly open-ended problem with no clear solution at the moment. The favicon work from last year helped a bit by allowing us to decode ICOs, but many sites still provide no high resolution icons. Perhaps some clever system to pick an image from the page to use as a thumbnail (comparably to how Facebook does when you post a hyperlink) is called for? Such a system could straightforwardly be plugged into the existing favicon caching system and get us nicer icons everywhere.

Favicons used for search engines are stored outside of the favicons database (the JS code that adds a new search engine fetches the icon from the db, encodes it as a base64 string and stores it again elsewhere:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#7040
).
Ew.

Bug 961600 covers this problem. We could then cause the icon used in search preferences to be kept in sync with the icon served by the site each time we visit it, as well as eliminating the duplication of data (and all the other nice things Richard mentions in the bug).
Depends on: 961600
Flags: needinfo?(chriskitching)
See Also: → 826400
Summary: Searched Engines added from Page Menu have smaller favicons → Searche Engines added from Page Menu have smaller favicons
Summary: Searche Engines added from Page Menu have smaller favicons → Search Engines added from Page Menu have smaller favicons
It seems that this affects the favicons from search suggestion list also.
Duplicate of this bug: 1136062
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.