1029548 - Add a toast notification for adding search engines from long tap

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Attachment: Screenshot of the toast notification

OS: Android 4.4.4 and 4.1.2
Devices: Alcatel One Touch, Nexus 4

Steps:
1. Go to bugzilla.mozilla.org
2. Tap Menu -> Page -> Add a Search Engine
3. Go back to the page bugzilla.mozilla.org
4. Long tap the search field - add search engine

Expected Result:
- for both actions a toast notification is displayed letting you know the a search engine is added

Actual Result: 
- for the addition from long tap on search field there is not toast notification added.

Comment 1

[Aaron Train [:aaronmt]]

The former is shown in the addOpenSearchEngine success callback 
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#6966 maybe similarly could be added or refactored for addEngine() in general

Comment 2

[amoghbl1]

Attachment: fix_1029548.patch

Patch to fix display of toast, it does so on adding the engine to list of saved search engines.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8458386 [details] [diff] [review]
fix_1029548.patch

Review of attachment 8458386 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks good, but in the interests of saving time in the future, you should read this:

  https://developer.mozilla.org/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

In particular, this patch has four lines of context rather than 8, so this should be in ~/.hgrc:

[diff]
git = 1
unified = 8
showfunc = true


You also need to make sure the patch has a description. Something like:

  hg qref -m "Bug 1029548 - Add a toast notification for adding search engines from long tap. r=rnewman"

will do this.

The rest of that section of the wiki will explain how to set your name in the patch, too.

When that's done we can mark this as reviewed and checkin-needed, and it'll get added to Firefox!

Comment 4

[amoghbl1]

Attachment: fix_1029548_v2.patch

Updated the patch as per your suggestions :rnewman.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/0f4ca87b15f8

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0f4ca87b15f8

Comment 7

[Teodora Vermesan (:TeoVermesan)]

When adding a search engine from long tap, a toast notification is displayed:" 'X' has been added as a search engine", so:
Verified as fixed on:
Device: Samsung Galaxy Tab (Android 4.2)
Builds:37 Nightly and 36 Aurora(2014-12-09), 35 beta 1 and 34 Release