Closed
Bug 1029551
Opened 10 years ago
Closed 10 years ago
Avoid clock skew issues with timestamps
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ferjm, Assigned: ferjm)
Details
Attachments
(1 file)
We need the equivalent of bug 1020859 for our ClientRequestHelper
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → ferjmoreno
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8445244 -
Flags: review?(josea.olivera)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8445244 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/19
Looks promising however you need to pass in the 'retryoK' parameter always otherwise you don't take care of the clock skew issue.
Attachment #8445244 -
Flags: review?(josea.olivera) → feedback+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8445244 -
Flags: review?(josea.olivera)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8445244 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/19
Left a comment on the PR. Please, have a look at it. Thanks!
Attachment #8445244 -
Flags: review?(josea.olivera)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8445244 -
Flags: review?(josea.olivera)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8445244 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/19
LGTM. r=me
Thanks for taking care of it.
Attachment #8445244 -
Flags: review?(josea.olivera) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/f2eb35ec27e22af2019110f1aefe832f40decf11
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•