102958 - Prefill CCK "Auto Proxy Config URL" will cause browser to crash

Status: VERIFIED FIXED

(CCK Graveyard :: CCK-General, defect)

Description

[Jimmy Uen]

Fill the CCK "Auto Proxy Config URL" with any valid or invalid URL. The bits 
will luanch on the initial install but after it will just crash.

The N6 browser bits works fine with valid or invalid Auto Proxy Config URL when 
set in Preferences.

See Bugzilla 98234 may have something in related to this problem.

Comment 1

[Jimmy Uen]

update QA to myself

Comment 2

[bobj]

Jimmy,
We need to figure out what CCK is doing different from the browser pref dialog.

Using a standard Netscape build:
1. Create a new profile, start and quit.
2. Save a copy of pref.js.
3. Restart.  Change the auto proxy prefs.  Quit.
4. Attach the both copies of prefs.js and all.js to this bug.

Customize the auto proxy values in a CCK build and then:
1. Create a new profile, start and quit.
2. Attach the prefs.js and all.js to this bug.

Comment 3

[Jimmy Uen]

Attachment: Standard Netscape build initial pref.js file before setting auto proxy URL

Comment 4

[Jimmy Uen]

Attachment: Standard Netscape build initial all.js file before setting auto proxy URL

Comment 5

[Jimmy Uen]

Attachment: Standard Netscape build pref.js file after setting auto proxy URL

Comment 6

[Jimmy Uen]

Attachment: Standard Netscape build all.js file after setting auto proxy URL

Comment 7

[Jimmy Uen]

Attachment: CCK build - prefs.js

Comment 8

[Jimmy Uen]

Attachment: CCK build - all.js

Comment 9

[bobj]

Jimmy, Thanks for the attachments.
But I don't see anything strange about the proxy prefs -- they look like I
expected...

I suppose we could diff all.js and see if there is something strange elsewhere.

Tao, 
   Can you try the CCK all.js and prefs.js with debug browser build and try to
figure out why it's crashing.

Comment 10

[bobj]

I diffed the standard and customized all.js files.  Besides the type and the
autoconfig, other proxy prefs are modified.

Jimmy, Please verify that you hit this problem if you only modify the type
and autoconfig.  Let's make sure that this is related to auto and not some
other proxy pref (e.g., socks, ssl, port #s).

Here's the diff:
340,342c340,342
< pref("network.proxy.autoconfig_url",        "");
< pref("network.proxy.type",                  0);
< pref("network.proxy.ftp",                   "");
---
> pref("network.proxy.autoconfig_url",       
"http://oasis.orst.edu:8080/proxy.pac");
> pref("network.proxy.type",              2);
> pref("network.proxy.ftp",                   "york.mcom.com");
344,345c344,345
< pref("network.proxy.gopher",                "");
< pref("network.proxy.gopher_port",           0);
---
> pref("network.proxy.gopher",                "york.mcom.com");
> pref("network.proxy.gopher_port",              0);
348,349c348,349
< pref("network.proxy.http",                  "");
< pref("network.proxy.http_port",             0);
---
> pref("network.proxy.http",                  "york.mcom.com");
> pref("network.proxy.http_port",              0);
352c352
< pref("network.proxy.ssl",                   "");
---
> pref("network.proxy.ssl",                   "york.mcom.com");
354,356c354,356
< pref("network.proxy.socks",                 "");
< pref("network.proxy.socks_port",            0);
< pref("network.proxy.socks_version",         5);
---
> pref("network.proxy.socks",                 "york.mcom.com");
> pref("network.proxy.socks_port",              0);
> pref("network.proxy.socks_version",              5);

Comment 11

[Jimmy Uen]

Attachment: CCK build new - all.js

Comment 12

[Jimmy Uen]

Attachment: CCK build new - pref.js

Comment 13

[Jimmy Uen]

Bob,
I have attached a newer all.js and pref.js files without the 
proxy;ftp,http..etc. stuffs. This still causes the browser to crash.

Comment 14

[Jimmy Uen]

With the standard Netscape build if I modify the all.js following two lines

pref("network.proxy.autoconfig_url",    "http://oasis.orst.edu:8080/proxy.pac");
pref("network.proxy.type",              2);

The browser will crash at startup.

Comment 15

[bobj]

Based on Jimmy's last comment, this seems like a browser, not a CCK bug.
Opened bug 103979.

Jimmy,
Did you generate a talkback report?
If so, please put the link to it bug 103979.

Comment 16

[tao]

HI, shruti:

Would you see if we can temporary take out o rgrey out the auto-config portion
of the Proxy Config UI since this is a Mozilla client problem?

Comment 17

[Shruti Vasudevan]

I'll temporarily remove the auto-config portion of the Proxy Config UI till bug
83984 or 103979 is fixed.

Comment 18

[Jimmy Uen]

Nope, no Talkback report is avaliable. It generates an error dialog box ~ 

netscp6.exe has generates errors and will be closed by Windows. You will need to
restart the program.
An error log is being created.

But it doesn't said where the error log is located. 

Comment 19

[Shruti Vasudevan]

Attachment: Commenting out code which displays automatic proxy configuration

Comment 20

[tao]

Comment on attachment 52984 [details] [diff] [review]
Commenting out code which displays automatic proxy configuration

r=tao provided you add comments explaining what
UI is removed and the
reason (bug ?????)

Comment 21

[bobj]

Just add to Proxy.ini something like:

; Disabled ability to set autoconfig proxies as default until browser bug is fixed.
; See bugzilla 103979 Crash if autoconfig proxies prefs enabled by the default.

We should close this bug, so QA can verify the workaround.
We should open a new bug, to restore this feature once the bug 103979 is fixed.

Comment 22

[Shruti Vasudevan]

Added comments and checked in patch. Marking fixed.

Comment 23

[Shruti Vasudevan]

Added comments and checked in patch. Marking fixed.

Comment 24

[Jimmy Uen]

Verified with CCK Build 2001-10-15-08.