Note: There are a few cases of duplicates in user autocompletion which are being worked on.

RTL locale support in locale picker

RESOLVED FIXED in Firefox 53

Status

()

Firefox for Android
Locale switching and selection
P4
normal
RESOLVED FIXED
3 years ago
6 months ago

People

(Reporter: rnewman, Assigned: maliu, Mentored)

Tracking

(Blocks: 2 bugs)

Trunk
Firefox 53
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
This bug covers displaying RTL locales in the locale picker itself. Making our settings fragments themselves RTL-aware is Bug 928663.

This bug *might* be a no-op, depending on how smart Android's list picker is.
(Reporter)

Updated

3 years ago
Blocks: 1029649

Comment 1

3 years ago
I'll have a go at this as soon as I set-up my development environment.
(Reporter)

Comment 2

3 years ago
Aymen: be aware that this is a very ambitious bug, and there is an implicit prerequisite: Fennec's UI doesn't support RTL locales at all right now, and to the best of my knowledge we don't ship any.

You should sync up with :gueroJeff to make sure that RTL/bidi efforts are all working together.
Flags: needinfo?(jbeatty)

Comment 3

3 years ago
(In reply to Richard Newman [:rnewman] from comment #2)

Well, maybe I ought to first try to fix a less tasking and difficult bug before thinking about this, in order to acquaint myself with the code and development process.
Hi Aymen,

Yes, I'm organizing a group of interested localizers/Android developers to work on RTL in Fennec. Let me add you to my list of interested people and I'll be in touch this week.

Richard, thanks for CC-ing me. There are about three-four people interested in being mentored through these RTL bugs. I'll have an email sent out by the end of the day with everyone (you, Finkle, and localizers) on it.
Flags: needinfo?(jbeatty)
Priority: -- → P4
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Assignee: nobody → max
Attachment #8823190 - Flags: review?(s.kaspari) → review?(ahunt)
ahunt: You recently reviewed a RTL patch - can you take this one too?

Comment 8

6 months ago
mozreview-review
Comment on attachment 8823190 [details]
Bug 1029646 - Update layout direction of configuration and DecorView,

https://reviewboard.mozilla.org/r/101776/#review105210

This looks sane to me!

Sorry for the delay, I forgot about my vacation backlog...
Attachment #8823190 - Flags: review?(ahunt) → review+
(Assignee)

Updated

6 months ago
Keywords: checkin-needed

Comment 9

6 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e763552b6cf
Update layout direction of configuration and DecorView, r=ahunt
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4e763552b6cf
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Blocks: 1319302
You need to log in before you can comment on or make changes to this bug.