1029646 - RTL locale support in locale picker

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Locale switching and selection, defect, P4)

Description

[Richard Newman [:rnewman]]

This bug covers displaying RTL locales in the locale picker itself. Making our settings fragments themselves RTL-aware is Bug 928663.

This bug *might* be a no-op, depending on how smart Android's list picker is.

Comment 1

[Aymen Qader]

I'll have a go at this as soon as I set-up my development environment.

Comment 2

[Richard Newman [:rnewman]]

Aymen: be aware that this is a very ambitious bug, and there is an implicit prerequisite: Fennec's UI doesn't support RTL locales at all right now, and to the best of my knowledge we don't ship any.

You should sync up with :gueroJeff to make sure that RTL/bidi efforts are all working together.

Comment 3

[Aymen Qader]

(In reply to Richard Newman [:rnewman] from comment #2)

Well, maybe I ought to first try to fix a less tasking and difficult bug before thinking about this, in order to acquaint myself with the code and development process.

Comment 4

[Jeff Beatty [:gueroJeff]]

Hi Aymen,

Yes, I'm organizing a group of interested localizers/Android developers to work on RTL in Fennec. Let me add you to my list of interested people and I'll be in touch this week.

Richard, thanks for CC-ing me. There are about three-four people interested in being mentored through these RTL bugs. I'll have an email sent out by the end of the day with everyone (you, Finkle, and localizers) on it.

Comment 5

[Max Liu [:maliu]]

Attachment: Bug 1029646 - Update layout direction of configuration and DecorView,

Review commit: https://reviewboard.mozilla.org/r/101776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101776/

Comment 6

[Max Liu [:maliu]]

Comment on attachment 8823190 [details]
Bug 1029646 - Update layout direction of configuration and DecorView,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/101776/diff/1-2/

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

ahunt: You recently reviewed a RTL patch - can you take this one too?

Comment 8

[Andrzej Hunt :ahunt]

Comment on attachment 8823190 [details]
Bug 1029646 - Update layout direction of configuration and DecorView,

https://reviewboard.mozilla.org/r/101776/#review105210

This looks sane to me!

Sorry for the delay, I forgot about my vacation backlog...

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e763552b6cf
Update layout direction of configuration and DecorView, r=ahunt

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4e763552b6cf