1029651 - [Vertical Homescreen] New Smart Collection does not appear above the hard pressed divider

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Johan Lorenzo [:jlorenzo]]

STR
1. Long press a divider
2. Add a Smart Collection

Expected result
Verify that the new Smart Collection is above the divider pressed in step 2 on the leftmost position.

Actual result
Smart collection is added below the pressed divider, sometimes on the right, sometimes in the middle, depending where you pressed on the divider.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Jacqueline and I discussed that offline. 

Do you confirm that the expected behavior is the correct one from a UX perspective?

Comment 2

[Jacqueline Savory [:jsavory] UX]

Yes, the expected behaviour is correct - the smart collection should appear in the group above the divider in the next available spot.

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Please give me feedback before adding some tests

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8447099 [details]
Github pull request

Clearing feedback for now. I think this actually might be a similar issue as bug 1028330. I think the icon is ok to be positioned to either side of the divider, but that we are perhaps using the wrong distance testing logic.

Bug 1028330 was closed, but I think it still might not be as accurate as it could be. That bug has a patch, but it didn't quite behave as expected. Take a look at that and let me know what you think.

Comment 5

[Cristian Rodriguez (:crdlc)]

I know that the distance is not calculated properly in the drag&drop although my new method calculates the right free slot as users expect when they install a collection, above/below dividers in the last or first slot respectively, did you test my patch?

Comment 6

[Kevin Grandon :kgrandon]

(In reply to Cristian Rodriguez (:crdlc) from comment #5)
> I know that the distance is not calculated properly in the drag&drop
> although my new method calculates the right free slot as users expect when
> they install a collection, above/below dividers in the last or first slot
> respectively, did you test my patch?

Hi Cristian,

Yes, I recall testing your patch, though I wasn't sure if it was the right approach at the time to take. Specing drag drop is tricky, and something that we have not really had the time to do. Before making change here I think it would be good to run it by UX for them to consider. To be honest, I was a fan of just selecting the closest item, but this may produce a more expected behavior. Looking again, I think I'm fine with your approach, but generally prefer to avoid adding complexity if we don't need it.

Jacqueline - this is currently about the position of creating smart collections. Currently if you long press on a divider to create a collection, we try to find the closest item, and insert the collection at this position. This patch changes that to insert either directly before or after the divider. Do you have a preference as to which solution we implement? Thanks!

Comment 7

[Kevin Grandon :kgrandon]

Jacqueline - just to clarify after reading comment 2. We *always* want collections to appear in the last available slot (or create a new row), if the users finger is above the divider. If the users finger is below the divider on the y-axis, it will appear directly after the divider, shifting remaining icons?

(Both of these actions hold true if the tap on the right side of the divider as well?)

Comment 8

[Jacqueline Savory [:jsavory] UX]

Hi Kevin, I've tried this one on my device and I think that the current implementation is better than what I originally propose. I would suggest we stick with the smart collection appearing the closest spot to the long press.

Comment 9

[Johan Lorenzo [:jlorenzo]]

No need to fix that bug then.