1029659 - [browser] X next to search bar appears oversized

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Tiffanie Shakespeare [:tif]]

STR:
1. Launch Browser
2. Observe icon to the right of the text field

Expected
Icon appears to be normal size

Actual
Icon appears to be stretched

Comment 1

[Tiffanie Shakespeare [:tif]]

Attachment: browser search

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 3

[Tiffanie Shakespeare [:tif]]

hmmm it's definitely smaller, but still appears fuzzy. I'm NI'ing Helen as we might need a new icon for this.

Thanks Pavel!

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Shot from Device

Comment 5

[Tiffanie Shakespeare [:tif]]

Attachment: browser

Your screenshot looks awesome! I don't know why mine doesn't look like that. I updated gaia/gecko today... :(

Gaia      57da30f405ba37a5d4844f32bb292271b81faee2
Gecko     https://hg.mozilla.org/mozilla-central/rev/a19e0434ea52
BuildID   20140625040202
Version   33.0a1

Comment 6

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8445762 [details]
Shot from Device

This looks awesome and how it should be on the device. IDK why the patch doesn't work on mine :-/

Comment 7

[Helen Huang [:HHuang]]

Hi, 

I've checked files in Gaia, all the sizes for this icon are there. Also, the icon's size in the screenshot is correct!

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Tiffanie,
ping me on IRC to talk about how you test the patches and I will help you to do it correctly :)

Comment 9

[Ben Francis [:benfrancis]]

Comment on attachment 8445351 [details] [review]
patch for Gaia/master

Thanks Pavel

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Ben :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/7ea88fac0821ae644976520d0a0f2898e026690d