Closed
Bug 1029672
Opened 10 years ago
Closed 10 years ago
ForkJoin.h:284:1: warning: multi-line comment [-Wcomment]
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
In mozilla-central today, I'm getting tons of instances of this build warning:
> js/src/vm/ForkJoin.h:284:1: warning: multi-line comment [-Wcomment]
(I'm using GCC 4.9, though I think it affects earlier versions as well.)
This is from the trailing "\" at the end of the ASCII art in this line:
http://hg.mozilla.org/mozilla-central/annotate/e86b84998b18/js/src/vm/ForkJoin.h#l284
...which was added in bug 1019304, as noted in bug 1019304 comment 12.
Assignee | ||
Comment 1•10 years ago
|
||
Back in bug 904184, we addressed this by replacing the //-style comment with a /**/-style comment.
I don't know of a better way to fix this.,.. I think the only alternative is to add another non-whitespace character after the "\", which would break the beautiful ASCII art a bit.
shu, would you be OK with that in this instance?
Flags: needinfo?(shu)
Comment 2•10 years ago
|
||
That little diagram is being changed in an upcoming patch to not contain any \ anyhow. r=me for any reformatting you want to do in the meantime to that diagram / comment.
Flags: needinfo?(shu)
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Shu-yu Guo [:shu] from comment #2)
> That little diagram is being changed in an upcoming patch to not contain any
> \ anyhow. r=me for any reformatting you want to do in the meantime to that
> diagram / comment.
OK, in that case, I'll just swap out the "\" for a "|". 1-character change, breaks the symmetry of the diagram a teeny bit, but doesn't matter if it's going away anyway.
Assignee | ||
Comment 4•10 years ago
|
||
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Flags: in-testsuite-
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•