1029672 - ForkJoin.h:284:1: warning: multi-line comment [-Wcomment]

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Daniel Holbert [:dholbert]]

In mozilla-central today, I'm getting tons of instances of this build warning:
> js/src/vm/ForkJoin.h:284:1: warning: multi-line comment [-Wcomment]

(I'm using GCC 4.9, though I think it affects earlier versions as well.)

This is from the trailing "\" at the end of the ASCII art in this line:

http://hg.mozilla.org/mozilla-central/annotate/e86b84998b18/js/src/vm/ForkJoin.h#l284
...which was added in bug 1019304, as noted in bug 1019304 comment 12.

Comment 1

[Daniel Holbert [:dholbert]]

Back in bug 904184, we addressed this by replacing the //-style comment with a /**/-style comment.

I don't know of a better way to fix this.,.. I think the only alternative is to add another non-whitespace character after the "\", which would break the beautiful ASCII art a bit.

shu, would you be OK with that in this instance?

Comment 2

[Shu-yu Guo [:shu]]

That little diagram is being changed in an upcoming patch to not contain any \ anyhow. r=me for any reformatting you want to do in the meantime to that diagram / comment.

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Shu-yu Guo [:shu] from comment #2)
> That little diagram is being changed in an upcoming patch to not contain any
> \ anyhow. r=me for any reformatting you want to do in the meantime to that
> diagram / comment.

OK, in that case, I'll just swap out the "\" for a "|".  1-character change, breaks the symmetry of the diagram a teeny bit, but doesn't matter if it's going away anyway.

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a997d84b6925

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a997d84b6925