Closed Bug 1029672 Opened 6 years ago Closed 6 years ago
Join .h:284:1: warning: multi-line comment [-Wcomment]
In mozilla-central today, I'm getting tons of instances of this build warning: > js/src/vm/ForkJoin.h:284:1: warning: multi-line comment [-Wcomment] (I'm using GCC 4.9, though I think it affects earlier versions as well.) This is from the trailing "\" at the end of the ASCII art in this line: http://hg.mozilla.org/mozilla-central/annotate/e86b84998b18/js/src/vm/ForkJoin.h#l284 ...which was added in bug 1019304, as noted in bug 1019304 comment 12.
Back in bug 904184, we addressed this by replacing the //-style comment with a /**/-style comment. I don't know of a better way to fix this.,.. I think the only alternative is to add another non-whitespace character after the "\", which would break the beautiful ASCII art a bit. shu, would you be OK with that in this instance?
That little diagram is being changed in an upcoming patch to not contain any \ anyhow. r=me for any reformatting you want to do in the meantime to that diagram / comment.
(In reply to Shu-yu Guo [:shu] from comment #2) > That little diagram is being changed in an upcoming patch to not contain any > \ anyhow. r=me for any reformatting you want to do in the meantime to that > diagram / comment. OK, in that case, I'll just swap out the "\" for a "|". 1-character change, breaks the symmetry of the diagram a teeny bit, but doesn't matter if it's going away anyway.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.