[e10s] Enable the layoutview tests with E10S

NEW
Assigned to

Status

defect
P3
normal
5 years ago
Last year

People

(Reporter: miker, Assigned: miker)

Tracking

(Depends on 1 bug, Blocks 2 bugs)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+)

Details

(Whiteboard: [e10s-m6])

Attachments

(1 attachment)

Repurposing... browser/devtools/layoutview/test/* should be re-enabled in browser/devtools/layoutview/test/browser.ini when they are E10S ready.

Another reason that these tests were disabled is because the mouse pointer on test boxes can produce unexpected mouseover events in tests, causing oranges depending on the test box mouse pointer.

To solve this issue we should set EventUtils.disableNonTestMouseEvents(true) in head.js for all devtools tests.

We are blocked by bug 1029451 because disableNonTestMouseEvents() incorrectly blocks synthetic mouse events but this shouldn't prevent us getting these tests ready for E10S.
Summary: Re-enable browser_layoutview_guides.js when bug 1029451 is fixed → Re-enable layoutview tests when they are E10S friendly and bug 1029451 is fixed
Duplicate of this bug: 1074840
tracking-e10s: --- → +
Moving DevTools test bugs to e10s milestone M7 (i.e. not blocking e10s merge to Aurora).
Whiteboard: [e10s-m7]
Hey Mike, what's the status on this bug? Is there anything we can do to unblock you?
Flags: needinfo?(mratcliffe)
(In reply to Eddy Bruel [:ejpbruel] from comment #5)
> Hey Mike, what's the status on this bug? Is there anything we can do to
> unblock you?

Sure, you could fix bug 1029451.

If the mouse pointer on a test box happens to be over one of the layout view regions it causes a mouseover event causing a fail... this can be fixed with EventUtils.disableNonTestMouseEvents(true).

When we set EventUtils.disableNonTestMouseEvents(true) it erroneously prevents us from programmatically triggering mouseover events in tests, breaking the test. This is because synthetic click and mouseover events have the event.isSynthesized property set to false (bug 1029451).

Because of this issue, the risk of a layout test failing currently depends on the mouse pointer position on the test box, which is less than ideal.
Flags: needinfo?(mratcliffe)
Whiteboard: [e10s-m7] → [e10s-m6]
Summary: Re-enable layoutview tests when they are E10S friendly and bug 1029451 is fixed → [e10s] Enable the layoutview tests with E10S
tromey fixed this on the platform side so we just need to disable none test mouse events from the JS side now.
Inspector's Bugs Triage - Filter on CLIMBING SHOES
Priority: -- → P3
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.