1029730 - (vertical-homescreen) Search field width changes slightly when invoked

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Peter La]

Attachment: SearchFieldWidthInconsistency.png

The search field pill shape currently shrinks when the user taps on it to invoke it.  The search field should stay exactly the same as on homescreen.

PLEASE NOTE:

I'm going to needinfo Eric Pang to make sure this is correct and that nothing intentional has changed with Search.  Please wait for Eric's 'OK' before proceeding to fix this bug.

Comment 1

[Peter La]

Eric - can you just 'OK' this if it looks correct?  I talked to Przemek and he said that when you guys spec'd Search, you asked for the search field to stay the same as homescreen in terms of size, positioning, etc.

Comment 2

[Eric Pang [:epang] UX]

(In reply to Peter La from comment #1)
> Eric - can you just 'OK' this if it looks correct?  I talked to Przemek and
> he said that when you guys spec'd Search, you asked for the search field to
> stay the same as homescreen in terms of size, positioning, etc.

Hi Peter, that's correct it should match the homescreen. Thanks!

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Fixed the issue, many thanks for your time Dale

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8447006 [details]
Github pull request

Good eyes :) I couldnt notice the difference until I looked very hard

Comment 5

[Cristian Rodriguez (:crdlc)]

Me neither :) But overlapping both screenshots I could see it. My eyes are not so good hahaha

(In reply to Dale Harvey (:daleharvey) from comment #4)
> Comment on attachment 8447006 [details]
> Github pull request
> 
> Good eyes :) I couldnt notice the difference until I looked very hard

Comment 6

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/c487ce5e7fde1dfc44f820349ec614bb4e5df344

Comment 7

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8447006 [details]
Github pull request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: text fields are a bit different in rocketbar and vertical home
[Testing completed]: added two pixels to the text field in the rocket bar to fit both in CSS
[Risk to taking this patch] (and alternatives if risky): close to null
[String changes made]: no

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 8447006 [details]
Github pull request

low risk css changes, looks good to land.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/984143a51cc7684be393998f83ed07f6c340fe79

Comment 10

[Elie]

Attachment: 008.png

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2