Add a pref for tab-modal auth prompts

NEW
Unassigned

Status

()

Toolkit
General
4 years ago
3 years ago

People

(Reporter: Dolske, Unassigned)

Tracking

unspecified
x86
All
Points:
3
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Tab-modal authentication prompts somewhat work today -- as long as you never have more than one at a time. They need significant technical work to make them more broadly functional, styling changes, and testing.

We should add a pref to enable use of tab-modal auth prompts. Due to the amount of work and known bugs, this should be a Nightly-only pref. In fact, we shouldn't even land this pref until we've got more of the kinks worked out, and have a plan/timeframe for finishing tab-modal work. I don't think this code will bitrot quickly, so developers working on tab-modal auth prompts can just locally add this patch.

The primary purpose of adding this pref is actually just so we can turn _off_ tab-modal prompts once they're on track to shipping as the default. (Per usual tree rules about being able to disable new features lest late-breaking issues arise.)
(Reporter)

Comment 1

4 years ago
Created attachment 8445381 [details] [diff] [review]
Example patch to force-enable tab-modal prompts.

This is a demonstration patch to force-enable tab-modal auth prompts. This should really be based on a pref-check.

TBD:
 - Might want this to go in nsLoginManagerPrompter instead [ie, have _doAsyncPrompt() call getPrompt() and setPropertyBag() instead of using directly calling the prompt service's promptAuth().]

 - I don't think we need the existing prompts.tab_modal.enabled pref any more, as I've not seen any bugs/complaints about needing to flip it due to our existing tab-modal prompts causing problems. I'd suggest we remove it and the existing pref-checking code to avoid any confusion.

Updated

4 years ago
Flags: firefox-backlog+
Points: --- → 3
You need to log in before you can comment on or make changes to this bug.