1029782 - Have OPEN_SECRETLY flag for opening cache entries

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement)

Description

[Honza Bambas (:mayhemer)]

This flag when specified should work the way to not update some of the "last-access" metadata on the entry, mainly frecency value.

Comment 1

[Honza Bambas (:mayhemer)]

Fetch count is currently implemented to count the number of fetches from disk, not the number of opens, which seems to me wrong.  Also changing that logic would make implementing this flag easier.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: preview 1

Comment 3

[Honza Bambas (:mayhemer)]

Taking back.

Comment 4

[Honza Bambas (:mayhemer)]

Attachment: v1

- nsICacheStorage::OPEN_SECRETLY
- doesn't update frecency, last modified, last fetched and fetch count
- does update it when opening for write or revalidating (the secret concept doesn't make sense in that case)

Comment 5

[Michal Novotny [:michal]]

Comment on attachment 8482932 [details] [diff] [review]
v1

Review of attachment 8482932 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/test/unit/test_cache2-28a-OPEN_SECRETLY.js
@@ +4,5 @@
> +  function NowSeconds() {
> +    return parseInt((new Date()).getTime() / 1000);
> +  }
> +  function do_check_time(a, b) {
> +    do_check_true(Math.abs(a - b) < 0.5);

The same as in bug 1000338 comment 5.

Comment 6

[Honza Bambas (:mayhemer)]

https://tbpl.mozilla.org/?tree=Try&rev=06c33a700f17

Comment 7

[Honza Bambas (:mayhemer)]

Attachment: v1.1

Comment 8

[Honza Bambas (:mayhemer)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/25c721fd5dc6

Comment 9

[Carsten Book [:Tomcat]]

sorry had to back this out for xpcshell bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=47869769&tree=Mozilla-Inbound

Comment 10

[Honza Bambas (:mayhemer)]

(In reply to Carsten Book [:Tomcat] from comment #9)
> sorry had to back this out for xpcshell bustage like
> https://tbpl.mozilla.org/php/getParsedLog.php?id=47869769&tree=Mozilla-
> Inbound

Didn't show on try...  Will check.

Comment 11

[Honza Bambas (:mayhemer)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5780024ea016

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5780024ea016