Have OPEN_SECRETLY flag for opening cache entries

RESOLVED FIXED in mozilla35

Status

()

enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

(Blocks 2 bugs)

Trunk
mozilla35
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

This flag when specified should work the way to not update some of the "last-access" metadata on the entry, mainly frecency value.
Fetch count is currently implemented to count the number of fetches from disk, not the number of opens, which seems to me wrong.  Also changing that logic would make implementing this flag easier.
Posted patch preview 1 (obsolete) — Splinter Review
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Summary: Have OPEN_SECRET flag for opening cache entries → Have OPEN_SECRETLY flag for opening cache entries
Blocks: 1009122
Blocks: cache2polish
Assignee: honzab.moz → sworkman
Depends on: 1000338
Taking back.
Assignee: sworkman → honzab.moz
Posted patch v1 (obsolete) — Splinter Review
- nsICacheStorage::OPEN_SECRETLY
- doesn't update frecency, last modified, last fetched and fetch count
- does update it when opening for write or revalidating (the secret concept doesn't make sense in that case)
Attachment #8445515 - Attachment is obsolete: true
Attachment #8482932 - Flags: review?(michal.novotny)
Comment on attachment 8482932 [details] [diff] [review]
v1

Review of attachment 8482932 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/test/unit/test_cache2-28a-OPEN_SECRETLY.js
@@ +4,5 @@
> +  function NowSeconds() {
> +    return parseInt((new Date()).getTime() / 1000);
> +  }
> +  function do_check_time(a, b) {
> +    do_check_true(Math.abs(a - b) < 0.5);

The same as in bug 1000338 comment 5.
Attachment #8482932 - Flags: review?(michal.novotny) → review+
Posted patch v1.1Splinter Review
Attachment #8482932 - Attachment is obsolete: true
Attachment #8487802 - Flags: review+
(In reply to Carsten Book [:Tomcat] from comment #9)
> sorry had to back this out for xpcshell bustage like
> https://tbpl.mozilla.org/php/getParsedLog.php?id=47869769&tree=Mozilla-
> Inbound

Didn't show on try...  Will check.
Blocks: 1067931
https://hg.mozilla.org/mozilla-central/rev/5780024ea016
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.